Allow multiple devfile registries to be specified #13999
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stalleyj
requested review from
ashumilova,
benoitf,
l0rd,
nickboldt and
rhopp
as code owners
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this PR? |
|
@stalleyj Are you able to fill out a contributor agreement? https://www.eclipse.org/legal/ECA.php Eclipse projects require this level of bla bla due diligence so we know YOU wrote the code, etc. |
|
@nickboldt Contributor agreement has been signed https://accounts.eclipse.org/users/jstalley/eca |
Signed-off-by: Julie Stalley <julie_stalley@uk.ibm.com>
Signed-off-by: Julie Stalley <julie_stalley@uk.ibm.com>
|
Sorry, couldn't amend the commit to be signed successfully so I have raised a new PR here #14059 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR allows multiple devfile registries to be specified as a space separated list, for example in values.yml we can have:-
che:
workspace:
devfileRegistryUrl: "https://che-devfile-registry.openshift.io/ https://raw.githubusercontent.com/kabanero-io/codewind-templates/master/"
The registry location is then stored so that the devfile can be read from the correct location.
What issues does this PR fix or reference?
Fixes #13961
Release Notes
Docs PR