Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theia Terminal plugin: add missing API and implement the Plugin #11442

Closed
4 tasks
l0rd opened this issue Oct 2, 2018 · 2 comments
Closed
4 tasks

Theia Terminal plugin: add missing API and implement the Plugin #11442

l0rd opened this issue Oct 2, 2018 · 2 comments
Labels
kind/epic A long-lived, PM-driven feature request. Must include a checklist of items that must be completed. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@l0rd
Copy link
Contributor

l0rd commented Oct 2, 2018

In Che 7 model, terminal connection logic may differ from upstream theia one:

  • Theia is connecting directly to a host
  • Che is connecting through a remote container exec

The goal of this issue is to be able to provide the logic through an extension point in Che. Che extension point would override the one defined in Theia.

List of missing Theia API to implement:

This split means: define common interface and default implementation for connection part to the separated Theia package: terminal. Xterm.js specific implementation of the terminal widget move to the separated package xterm.js-terminal

  • terminal widget api with ability:
    • Create new terminal widget
    • Ability apply widget to the bottom panel.
    • Ability resize terminal widget.
    • Ability send text to the terminal widget.
    • Ability destroy terminal widget.
    • Ability track user input from terminal widget.
  • rework che-theia-terminal-extension to the plugin. We should use terminal widget api to create new terminal in the plugin and wrote connection logic for stdin/stdout for terminal widget.
  • rename repository from che-the-terminal-extension to the che-theia-terminal-plugin.
@che-bot
Copy link
Contributor

che-bot commented Sep 7, 2019

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 7, 2019
@l0rd
Copy link
Contributor Author

l0rd commented Sep 14, 2019

Already implement ed

@l0rd l0rd closed this as completed Sep 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/epic A long-lived, PM-driven feature request. Must include a checklist of items that must be completed. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

2 participants