Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split Theia terminal widget logic #12609

Closed
evidolob opened this issue Feb 6, 2019 · 1 comment
Closed

Split Theia terminal widget logic #12609

evidolob opened this issue Feb 6, 2019 · 1 comment
Assignees
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@evidolob
Copy link
Contributor

evidolob commented Feb 6, 2019

Description

Sub task of #11442
Split terminal widget logic:

  • terminal widget part (without any connection logic).
  • terminal connection logic.

This split means: define common interface and default implementation for connection part to the separated Theia package: terminal. Xterm.js specific implementation of the terminal widget move to the separated package xterm.js-terminal

@che-bot
Copy link
Contributor

che-bot commented Sep 7, 2019

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 7, 2019
@che-bot che-bot closed this as completed Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

3 participants