This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
Improve displaying output for che commands in output channel #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
RomanNikitenko
requested review from
olexii4,
sunix and
vitaliy-guliy
as code owners
AndrienkoAleksandr
approved these changes
Apr 25, 2019
sunix
approved these changes
Apr 26, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It was temporary solution to display output of a command to output channel. Within this issue we depend on eclipse-che/che#11442
So this PR is a workaround to improve displaying output for che commands in output channel
Then we switch task's output from output channel to terminal widget when eclipse-che/che#11442 is resolved.
What issues does this PR fix or reference?
#192
Signed-off-by: Roman Nikitenko rnikiten@redhat.com