Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

Do not store state of Welcome page #848

Merged
merged 1 commit into from
Sep 17, 2020
Merged

Conversation

vitaliy-guliy
Copy link
Contributor

Signed-off-by: Vitaliy Guliy vgulyy@redhat.com

What does this PR do?

Disables saving the state of Welcome page.

Why do we need to do this:

  • the plugin doesn't take into account that after reload the page, Theia restores all the views, including the previously opened Welcome page
  • after restoring the state, links in the webview become not working

Depends on eclipse-theia/theia#8473

What issues does this PR fix or reference?

Happy Path Channel

HAPPY_PATH_CHANNEL=stable

@che-bot
Copy link
Contributor

che-bot commented Sep 4, 2020

✅ E2E Happy path tests succeed 🎉

Try Che-Theia editor only Try Che-Theia with Java/maven example Try Che-Theia with NodeJs example

See Details

name link
che-theia docker.io/maxura/che-theia:848
che-theia-endpoint-runtime-binary docker.io/maxura/che-theia-endpoint-runtime-binary:848

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

@vzhukovs
Copy link
Contributor

vzhukovs commented Sep 6, 2020

[ci-build]

Signed-off-by: Vitaliy Gulyy <vgulyy@redhat.com>
@che-bot
Copy link
Contributor

che-bot commented Sep 16, 2020

✅ E2E Happy path tests succeed 🎉

Try Che-Theia editor only Try Che-Theia with Java/maven example Try Che-Theia with NodeJs example

See Details

name link
che-theia docker.io/maxura/che-theia:848
che-theia-endpoint-runtime-binary docker.io/maxura/che-theia-endpoint-runtime-binary:848

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

@vitaliy-guliy vitaliy-guliy merged commit bb61966 into master Sep 17, 2020
@vitaliy-guliy vitaliy-guliy deleted the serialize-webview branch September 17, 2020 08:54
@che-bot che-bot added this to the 7.20 milestone Sep 17, 2020
ericwill pushed a commit to ericwill/che-theia that referenced this pull request Sep 22, 2020
See eclipse-che/che#16563

Signed-off-by: Eric Williams <ericwill@redhat.com>
ericwill pushed a commit to ericwill/che-theia that referenced this pull request Sep 22, 2020
See eclipse-che/che#16563

Signed-off-by: Eric Williams <ericwill@redhat.com>
ericwill added a commit to ericwill/che-theia that referenced this pull request Sep 22, 2020
See eclipse-che/che#16563

Signed-off-by: Eric Williams <ericwill@redhat.com>
azatsarynnyy pushed a commit that referenced this pull request Sep 22, 2020
See eclipse-che/che#16563

Signed-off-by: Eric Williams <ericwill@redhat.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants