Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new welcome page every time when I refresh my workspace #16352

Closed
5 tasks done
vitaliy-guliy opened this issue Mar 13, 2020 · 2 comments
Closed
5 tasks done

new welcome page every time when I refresh my workspace #16352

vitaliy-guliy opened this issue Mar 13, 2020 · 2 comments
Assignees
Labels
area/plugins kind/bug Outline of a bug - must adhere to the bug report template. severity/P2 Has a minor but important impact to the usage or development of the system.
Milestone

Comments

@vitaliy-guliy
Copy link
Contributor

Describe the bug

Che-Theia always open a new Welcome page when refreshing the workspace.
It looks like the bug is appeared after merging this PR eclipse-che/che-theia#605
I have a strong opinion that we have to revert that branch.
We don't need to store the Welcome page, let the welcome plugin decide whether it should be opened or not (depends on config in preferences).
BTW, on restored welcome page, hyperlinks with commands does not work.

Screencast with the bug https://youtu.be/Ija0oU-i2AY

Che version

  • latest
  • nightly

Steps to reproduce

  1. Create and open a workspace.
  2. Refresh the browser.
  3. Refresh the browser.
  4. ...

Expected behavior

One welcome page with working hyperlinks.

Runtime

  • minikube (include output of minikube version and kubectl version)

Screenshots

Environment

  • my computer
    • Linux
@vitaliy-guliy vitaliy-guliy added the kind/bug Outline of a bug - must adhere to the bug report template. label Mar 13, 2020
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Mar 13, 2020
@tolusha tolusha added severity/P2 Has a minor but important impact to the usage or development of the system. area/editor/theia Issues related to the che-theia IDE of Che and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Mar 13, 2020
@benoitf benoitf changed the title +1 welcome page every time when I refresh my workspace new welcome page every time when I refresh my workspace Mar 26, 2020
@benoitf benoitf added area/plugins and removed area/editor/theia Issues related to the che-theia IDE of Che labels Aug 20, 2020
@ericwill ericwill mentioned this issue Aug 20, 2020
32 tasks
@vitaliy-guliy
Copy link
Contributor Author

vitaliy-guliy commented Sep 4, 2020

To solve this issue need to be merged

@azatsarynnyy
Copy link
Member

FYI: Che Theia is already aligned with upstream Theia eclipse-che/che-theia#823
So, you can check if the issue is solved.

@ericwill ericwill modified the milestones: 7.22, 7.23 Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/plugins kind/bug Outline of a bug - must adhere to the bug report template. severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
None yet
Development

No branches or pull requests

6 participants