Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: CheCluster defaults #1407

Merged
merged 4 commits into from
Jun 22, 2022
Merged

feat: CheCluster defaults #1407

merged 4 commits into from
Jun 22, 2022

Conversation

tolusha
Copy link
Contributor

@tolusha tolusha commented Jun 17, 2022

Signed-off-by: Anatolii Bazko abazko@redhat.com

What does this PR do?

Set CheCluster defaults

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

eclipse-che/che#20804

How to test this PR?

oc create namespace eclipse-che
oc apply -f config/crd/bases/org.eclipse.che_checlusters.yaml
oc apply -f config/samples/org_v2_checluster.yaml -n eclipse-che 
oc get checluster/eclipse-che -o yaml -n eclipse-che

Check defaults values are set:

spec:
  components:
    cheServer:
      debug: false
      logLevel: INFO
    database:
      credentialsSecretName: postgres-credentials
      externalDb: false
      postgresDb: dbche
      postgresHostName: postgres
      postgresPort: "5432"
      pvc:
        claimSize: 1Gi
    metrics:
      enable: true
  containerRegistry: {}
  devEnvironments:
    defaultNamespace:
      template: <username>-che
    storage:
      pvcStrategy: common
  networking:
    auth:
      gateway:
        configLabels:
          app: che
          component: che-gateway-config

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@openshift-ci
Copy link

openshift-ci bot commented Jun 17, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tolusha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@tolusha tolusha requested a review from l0rd June 17, 2022 14:05
@codecov
Copy link

codecov bot commented Jun 17, 2022

Codecov Report

Merging #1407 (8e1ac6f) into main (08de5aa) will increase coverage by 0.03%.
The diff coverage is n/a.

❗ Current head 8e1ac6f differs from pull request most recent head 9437ea6. Consider uploading reports for the commit 9437ea6 to get more accurate results

@@            Coverage Diff             @@
##             main    #1407      +/-   ##
==========================================
+ Coverage   63.27%   63.30%   +0.03%     
==========================================
  Files          70       70              
  Lines        5827     5824       -3     
==========================================
  Hits         3687     3687              
+ Misses       1777     1774       -3     
  Partials      363      363              
Impacted Files Coverage Δ
controllers/che/checluster_validator.go 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08de5aa...9437ea6. Read the comment docs.

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@tolusha
Copy link
Contributor Author

tolusha commented Jun 20, 2022

/retest

@openshift-ci
Copy link

openshift-ci bot commented Jun 20, 2022

@tolusha: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v9-devworkspace-happy-path 9437ea6 link true /test v9-devworkspace-happy-path

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@tolusha tolusha merged commit 38f6cb6 into main Jun 22, 2022
@tolusha tolusha deleted the 20804 branch June 22, 2022 08:02
@che-bot che-bot added this to the 7.50 milestone Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants