Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve a way how operator handle CheCluster CR #20804

Closed
3 of 5 tasks
Tracked by #21395 ...
tolusha opened this issue Nov 22, 2021 · 1 comment
Closed
3 of 5 tasks
Tracked by #21395 ...

Improve a way how operator handle CheCluster CR #20804

tolusha opened this issue Nov 22, 2021 · 1 comment
Labels
area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system.
Milestone

Comments

@tolusha
Copy link
Contributor

tolusha commented Nov 22, 2021

Is your enhancement related to a problem? Please describe

There several areas where we can improve how operator handles CheCluster CR.
Some changes aren't possible until we support OCP 3.11 and use corresponding apiextensions.k8s.io/v1beta1 API.

Describe the solution you'd like

  • Operator must not update CR spec from the code. It is only allowed to update status fields.
  • Use kubebuilder:default to set default values for fields
  • Use MutatingWebhook to set record level defaults
  • Use kubebuilder:validation to set field validation
  • Use ValidatingWebhook for record level validation

https://book.kubebuilder.io/reference/markers/crd-validation.html
https://kubernetes.io/docs/reference/access-authn-authz/extensible-admission-controllers/
https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.22/#mutatingwebhookconfiguration-v1-admissionregistration-k8s-io
https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.22/#validatingwebhookconfiguration-v1-admissionregistration-k8s-io

Describe alternatives you've considered

No response

Additional context

No response

@tolusha tolusha added kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system. area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator labels Nov 22, 2021
@tolusha tolusha mentioned this issue May 13, 2022
49 tasks
@che-bot
Copy link
Contributor

che-bot commented May 21, 2022

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 21, 2022
@tolusha tolusha removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 23, 2022
@tolusha tolusha closed this as completed Jun 22, 2022
@tolusha tolusha added this to the 7.50 milestone Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Development

No branches or pull requests

2 participants