Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release notes about mountSources. #675

Merged
merged 1 commit into from
Feb 25, 2019

Conversation

metlos
Copy link
Contributor

@metlos metlos commented Feb 5, 2019

What does this PR do?

This PR adds release notes about the mountSources attribute in che-plugin.yaml.

What issues does this PR fix or reference?

eclipse-che/che#12510

@skabashnyuk
Copy link
Contributor

CC @dneary. @slemeur @rkratky can you take a look too?

Copy link
Contributor

@slemeur slemeur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!
@dneary make sure that this is callout as a feature/capability that is dedicated to Che 7.

Copy link
Contributor

@dneary dneary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this for 6.18 or 6.19? Just checking when the change landed.

@skabashnyuk
Copy link
Contributor

6.18

@dneary
Copy link
Contributor

dneary commented Feb 12, 2019

Thanks - and can I have an example of how plug-ins worked when they did not have access to the source code? Did they have to request a text buffer from somewhere, or something? I'm looking for an illustrative example of how this enables something new for plug-in writer.

@metlos
Copy link
Contributor Author

metlos commented Feb 20, 2019

@dneary - there was the possibility to manually define a volume mount that would make the sources available to the plugin. mountSources makes that process simpler, but more importantly it makes sure that all plugins get the sources mounted on the same location, as explained in the release note.

Copy link
Contributor

@dneary dneary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the text needs some clarification, but I will propose a revision in a follow-on commit. Thank you @metlos!

@dneary dneary merged commit c8c60ae into eclipse-che:master Feb 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants