Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement mountSources boolean attribute in che-plugin.yaml #12510

Closed
metlos opened this issue Jan 24, 2019 · 1 comment
Closed

Implement mountSources boolean attribute in che-plugin.yaml #12510

metlos opened this issue Jan 24, 2019 · 1 comment
Assignees
@metlos
Labels
kind/enhancement A feature request - must adhere to the feature request template.

Comments

@metlos
Copy link
Contributor

metlos commented Jan 24, 2019

Description

introduce mountSources boolean attribute in che-plugin.yaml. When set to true, it will cause the projects volume to be mounted on /projects path.

Remove the possibility to mount the projects using the "free-form" volume mounting. This is so that we can guarantee that the sources are mounted on the same path in all the sidecar containers.
@metlos metlos added kind/enhancement A feature request - must adhere to the feature request template. status/in-progress This issue has been taken by an engineer and is under active development. team/platform labels Jan 24, 2019
@metlos metlos self-assigned this Jan 24, 2019
This was referenced Jan 28, 2019
Merged
Merged
Closed
Closed
@skabashnyuk skabashnyuk mentioned this issue Jan 30, 2019
Closed
13 tasks
@metlos metlos mentioned this issue Feb 5, 2019
Merged
@metlos
Copy link
Contributor Author

metlos commented Feb 5, 2019

#12527 is done including docs PRs, so this can be closed now.

@metlos metlos closed this as completed Feb 5, 2019
@sleshchenko sleshchenko removed the status/in-progress This issue has been taken by an engineer and is under active development. label Feb 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@metlos metlos

Labels
kind/enhancement A feature request - must adhere to the feature request template.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@metlos @sleshchenko