Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on /user and /profile API #657

Merged
merged 4 commits into from
Nov 2, 2022
Merged

Remove dependency on /user and /profile API #657

merged 4 commits into from
Nov 2, 2022

Conversation

akurinnoy
Copy link
Contributor

What does this PR do?

This PR removes the dependency on /user and /profile che-server API. Instead, the dashboard backend gets a new endpoint /userprofile that allows retrieving the email and username. Additionally, the Account page gets temporarily hidden as it will be reworked in further PRs.

What issues does this PR fix or reference?

resolves eclipse-che/che#21595

@akurinnoy akurinnoy self-assigned this Oct 26, 2022
@che-bot
Copy link
Contributor

che-bot commented Oct 26, 2022

Click here to review and test in web IDE: Contribute

@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-657

@che-bot
Copy link
Contributor

che-bot commented Oct 26, 2022

Click here to review and test in web IDE: Contribute

@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-657

@che-bot
Copy link
Contributor

che-bot commented Nov 1, 2022

Click here to review and test in web IDE: Contribute

@github-actions
Copy link

github-actions bot commented Nov 1, 2022

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-657

Copy link
Contributor

@olexii4 olexii4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci
Copy link

openshift-ci bot commented Nov 1, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, olexii4

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the lgtm label Nov 1, 2022
@openshift-ci
Copy link

openshift-ci bot commented Nov 1, 2022

New changes are detected. LGTM label has been removed.

@che-bot
Copy link
Contributor

che-bot commented Nov 1, 2022

Click here to review and test in web IDE: Contribute

@github-actions
Copy link

github-actions bot commented Nov 1, 2022

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-657

@openshift-ci
Copy link

openshift-ci bot commented Nov 1, 2022

@akurinnoy: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v10-dashboard-happy-path 545965c link true /test v10-dashboard-happy-path

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@akurinnoy akurinnoy merged commit bc9f117 into main Nov 2, 2022
@akurinnoy akurinnoy deleted the che-21595 branch November 2, 2022 08:23
@che-bot che-bot added this to the 7.56 milestone Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "Git Services" tab to the User Preferences
3 participants