Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Git Services" tab to the User Preferences #21595

Closed
2 tasks
Tracked by #20583 ...
ibuziuk opened this issue Jul 28, 2022 · 5 comments · Fixed by eclipse-che/che-dashboard#657 or eclipse-che/che-dashboard#687
Closed
2 tasks
Tracked by #20583 ...
Assignees
Labels
area/dashboard area/ux Issues related to User Experience Design kind/task Internal things, technical debt, and to-do tasks to be performed. new&noteworthy For new and/or noteworthy issues that deserve a blog post, new docs, or emphasis in release notes severity/P1 Has a major impact to usage or development of the system. sprint/current status/release-notes-review-needed Issues that needs to be reviewed by the doc team for the Release Notes wording
Milestone

Comments

@ibuziuk
Copy link
Member

ibuziuk commented Jul 28, 2022

Is your task related to a problem? Please describe

image

Currently, the account page is outdated and fetches the user information from db that is planned to be removed as part of #21374

The data provided on the Account page is irrelevant and should be removed

Describe the solution you'd like

As part of this issue, we should only have the login / logout buttons to the main Git providers GitHub, Gitlab, and Bitbucketlogin/logout

Sub-tasks

  • remove dependecy on /user and /profile API (display only username from k8s as the first step)
    • hide 'Account' view
  • [ ]

Describe alternatives you've considered

Potentially we should remove Account page completely and add Git Services Tab to the User Preferences:

image

Additional context

The information about the configuration of the particular Git provider should be fetched from the Eclipse Che CR - #21577

The issue is part of the Git Zero Config epic - #20583

Open Questions:

  • login / logout URLs should be provided by the Che CR
  • how should we track the login / logout state for a particular user

Release Notes Text

Eclipse Che User Preferences page includes a new tab: "Git Services" (before, the only tab was "Container Registries"). This tab shows the list of git services the user has granted access to. User can revoke access to any of the git services from this tab. Supported services are GitHub (github.com or Enterprise), GitLab (SaaS and Server) or Bitbucket (Cloud and Server).

@ibuziuk ibuziuk added the kind/task Internal things, technical debt, and to-do tasks to be performed. label Jul 28, 2022
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Jul 28, 2022
@ibuziuk ibuziuk added area/dashboard severity/P1 Has a major impact to usage or development of the system. sprint/next and removed sprint/next status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Jul 28, 2022
@ibuziuk ibuziuk changed the title Rework "Account" page on the User Dashboard. Add login / logout buttons for GitHub / GitLab / BitBucket Rework (potentially remove) "Account" page on the User Dashboard. Add login / logout buttons for GitHub / GitLab / BitBucket Jul 28, 2022
@ibuziuk ibuziuk mentioned this issue Aug 9, 2022
67 tasks
@ibuziuk ibuziuk mentioned this issue Oct 7, 2022
67 tasks
@ibuziuk
Copy link
Member Author

ibuziuk commented Oct 18, 2022

As the first step, it would be great to remove the dependency on the server /user API

image

@akurinnoy akurinnoy self-assigned this Oct 21, 2022
@ibuziuk ibuziuk reopened this Nov 2, 2022
@ibuziuk ibuziuk mentioned this issue Nov 2, 2022
73 tasks
@ibuziuk ibuziuk added the area/ux Issues related to User Experience Design label Nov 3, 2022
@ibuziuk ibuziuk assigned ibuziuk and unassigned ibuziuk and akurinnoy Nov 3, 2022
@ibuziuk
Copy link
Member Author

ibuziuk commented Nov 15, 2022

@l0rd @akurinnoy @olexii4 please, find the proposed UX for Git Services
image

Git Services

Basically, the idea is that a particular icon is shown only if the admin configured the git service on the CR level accordingly - #21577

The only possible options would be login / logout from the dropdown

@ibuziuk ibuziuk mentioned this issue Nov 18, 2022
68 tasks
@ibuziuk
Copy link
Member Author

ibuziuk commented Nov 21, 2022

after discussion with @l0rd for Git Services Tab we want to have the very same UX as we currently have for the "Container Registries"

image

Important notes:

  • for the first iteration it should not be possible to add a 'Git Service' from UD
  • UD shows a 'Git Service' in the table based on the git-credential-secret from the user namespace
  • When a user deletes a 'Git Service' the corresponding secret is removed from the namespace and the access from the OAuth app is revoked

@ibuziuk ibuziuk removed their assignment Nov 21, 2022
@l0rd
Copy link
Contributor

l0rd commented Nov 22, 2022

When implementing this we should address the bug described in this Dev Spaces issue too.

@ibuziuk ibuziuk changed the title Rework (potentially remove) "Account" page on the User Dashboard. Add login / logout buttons for GitHub / GitLab / BitBucket Add "Git Servies" tab to the User Preferences Nov 30, 2022
@ibuziuk ibuziuk mentioned this issue Dec 13, 2022
82 tasks
@dkwon17 dkwon17 changed the title Add "Git Servies" tab to the User Preferences Add "Git Services" tab to the User Preferences Dec 13, 2022
@ibuziuk ibuziuk mentioned this issue Jan 10, 2023
60 tasks
@l0rd l0rd added new&noteworthy For new and/or noteworthy issues that deserve a blog post, new docs, or emphasis in release notes status/release-notes-review-needed Issues that needs to be reviewed by the doc team for the Release Notes wording labels Jan 19, 2023
@l0rd l0rd added this to the 7.60 milestone Jan 19, 2023
@eclipse-che eclipse-che deleted a comment from devstudio-release Jan 20, 2023
@devstudio-release
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dashboard area/ux Issues related to User Experience Design kind/task Internal things, technical debt, and to-do tasks to be performed. new&noteworthy For new and/or noteworthy issues that deserve a blog post, new docs, or emphasis in release notes severity/P1 Has a major impact to usage or development of the system. sprint/current status/release-notes-review-needed Issues that needs to be reviewed by the doc team for the Release Notes wording
Projects
None yet
6 participants