Populate properties window on click of a row in events table #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
fixes #348 Signed-off-by: muddana-satish <satish.muddana@ericsson.com>
ghost
self-assigned this
MatthewKhouzam
approved these changes
May 11, 2021
bhufmann
approved these changes
May 19, 2021
I think in the Properties view, if the key is "Source" the TraceExplorerTooltipWidget assumes that the value is a source code location. It tries to match filename and line number and adds a handler to open the file. The assumption is not always correct, because the Source column could be, for example, source IP address or similar things. So, this source code lookup feature will need to be addressed differently (more standardize), which is outside the scope of this PR. I'll open a new PR for to track this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #348
Signed-off-by: muddana-satish satish.muddana@ericsson.com