Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve source code lookup feature #376

Open
bhufmann opened this issue May 19, 2021 · 0 comments
Open

Improve source code lookup feature #376

bhufmann opened this issue May 19, 2021 · 0 comments
Labels
Theia UI frontend trace server protocol Needs changes to the trace-server-protocol itself Trace Server Involve changes in the trace server itself (in the incubator source code)
Milestone

Comments

@bhufmann
Copy link
Collaborator

For later, let's handle hyperlinks?

I think in the Properties view, if the key is "Source" the TraceExplorerTooltipWidget assumes that the value is a source code location. It tries to match filename and line number and adds a handler to open the file. The assumption is not always correct, because the Source column could be, for example, source IP address or similar things. So, this source code lookup feature will need to be addressed differently (more standardize), which is outside the scope of this PR. I'll open a new PR for to track this.

Originally posted by @bhufmann in #357 (comment)

@bhufmann bhufmann added Theia UI frontend Trace Server Involve changes in the trace server itself (in the incubator source code) trace server protocol Needs changes to the trace-server-protocol itself labels May 19, 2021
@bhufmann bhufmann added this to the 1.0 milestone May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Theia UI frontend trace server protocol Needs changes to the trace-server-protocol itself Trace Server Involve changes in the trace server itself (in the incubator source code)
Projects
None yet
Development

No branches or pull requests

1 participant