Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Time Graph: Align row labels with rows (recent Chrome only) #433

Closed
ebugden opened this issue Jul 30, 2021 · 4 comments
Closed

Time Graph: Align row labels with rows (recent Chrome only) #433

ebugden opened this issue Jul 30, 2021 · 4 comments
Assignees
@Rodrigoplp-work
Labels
bug Something isn't working timeline-chart Involves changes in the timeline chart project: https://github.com/theia-ide/timeline-chart
Milestone
MVP

Comments

@ebugden
Copy link
Contributor

ebugden commented Jul 30, 2021 •
edited
Loading

On recent Chrome browsers, there is a large vertical offset between where the chart starts and where line labels start so labels do not line up with the associated rows. (Row information is still available using the tooltip, but this isn't convenient)

  • Observed in both Resources Status and Thread Status views, so bug assumed present in all timegraph views.
  • Browser: Chrome, Version 92.0.4515.107

bhufmann: This problem only started with recent Chrome versions. Older Chrome versions or Firefox (v90.0) don't have that issue. I don't know which version it started, but with Chrome version 92.0.4515.107 it fails.

TraceCompassTutorialTraces.Theia-Trace.Example.Application.-.Google.Chrome.2021-07-28.12-51-12.mp4
@ebugden ebugden added the bug Something isn't working label Jul 30, 2021
@ebugden ebugden added this to the MVP milestone Jul 30, 2021
@ebugden ebugden added the timeline-chart Involves changes in the timeline chart project: https://github.com/theia-ide/timeline-chart label Jul 30, 2021
@ebugden
Copy link
Contributor Author

ebugden commented Jul 30, 2021

Let me know if this is too specific to the timeline chart and should be moved to the timeline-chart repo issues.

@bhufmann
Copy link
Collaborator

Let me know if this is too specific to the timeline chart and should be moved to the timeline-chart repo issues.

I think that the problem needs to be fixed here because the tree implementation and row synchronization is in the theia-trace-extension. So, let's keep the tracker here.

@bhufmann
Copy link
Collaborator

@ebugden This problem only started with recent Chrome versions. Older Chrome versions or Firefox (v90.0) don't have that issue. I don't know which version it started, but with Chrome version 92.0.4515.107 it fails.

@ebugden
Copy link
Contributor Author

ebugden commented Jul 30, 2021

Ok, thanks for the context! I'll add it in the issue description.

@ebugden ebugden changed the title Time Graph: Align row labels with rows Time Graph: Align row labels with rows (recent Chrome only) Jul 30, 2021
@ebugden ebugden mentioned this issue Jul 30, 2021
Closed
@MatthewKhouzam MatthewKhouzam mentioned this issue Jul 31, 2021
Open
@Rodrigoplp-work Rodrigoplp-work self-assigned this Aug 9, 2021
Rodrigoplp-work added a commit to Rodrigoplp-work/theia-trace-extension that referenced this issue Aug 11, 2021
@Rodrigoplp-work
Fix labels and rows misalignemnt.
b6abf10 
Fix misalignment between labels and rows in the Resouces Status and Thread Status views.

Fixes eclipse-cdt-cloud#433.

Signed-off-by: Rodrigo Pinto <rodrigo.pinto@calian.ca>
paul-marechal pushed a commit to paul-marechal/theia-trace-extension that referenced this issue Sep 14, 2021
@Rodrigoplp-work @paul-marechal
Fix labels and rows misalignemnt.
a4c12b1 
Fix misalignment between labels and rows in the Resouces Status and Thread Status views.

Fixes eclipse-cdt-cloud#433.

Signed-off-by: Rodrigo Pinto <rodrigo.pinto@calian.ca>
hriday-panchasara pushed a commit to hriday-panchasara/theia-trace-extension that referenced this issue Nov 10, 2021
@Rodrigoplp-work @hriday-panchasara
Fix labels and rows misalignemnt.
3984692 
Fix misalignment between labels and rows in the Resouces Status and Thread Status views.

Fixes eclipse-cdt-cloud#433.

Signed-off-by: Rodrigo Pinto <rodrigo.pinto@calian.ca>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Rodrigoplp-work Rodrigoplp-work

Labels
bug Something isn't working timeline-chart Involves changes in the timeline chart project: https://github.com/theia-ide/timeline-chart
Projects
None yet
Milestone
MVP
Development

No branches or pull requests
3 participants
@bhufmann @ebugden @Rodrigoplp-work