Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing chart elements #436

Open
MatthewKhouzam opened this issue Jul 31, 2021 · 4 comments
Open

Missing chart elements #436

MatthewKhouzam opened this issue Jul 31, 2021 · 4 comments
Milestone

Comments

@MatthewKhouzam
Copy link
Contributor

MatthewKhouzam commented Jul 31, 2021

Here is a list of core elements or information that are missing from certain chart types or views that make it difficult (or impossible) to use the results of the analysis. In some cases, this makes the view non-functional in practice. Related issues shown next to comment.

Chart type

Gantt Chart (Timeline chart)

ex. Resources Status, Thread Status

  • Does bar colour mean something?
    • The state. If a color repeats it is probably the same state. We have a limited palette so color re-use occurs. (MatthewKhouzam)
  • Does bar thickness mean something?
    • Width = duration
    • Height = either the state, there are height differences to help red-green colorblind users. IRQs are less high than userspace.
    • For frequency, higher = moar megahurts. (MatthewKhouzam)
  • There is a large vertical offset between where the chart starts and where line labels start. So labels do not line up with the associated rows. (Row information is still available using the tooltip, but this isn't convenient) Time Graph: Align row labels with rows (recent Chrome only) #433

Resources Status

Description: "Show the state of CPUs (SYSCALL, RUNNING, IRQ, SOFT_IRQ or IDLE) and its IRQs/SOFT_IRQs as well as its frequency."

  • How is the state of CPUs shown? The description "Show the state of CPUs (SYSCALL, RUNNING, IRQ," etc. implies that there would be chart elements labelled with those states
    • A given row is the an aspect of the state of the CPU. (MatthewKhouzam)
  • This view also includes process/thread information?

image

Thread Status

Description: "Show the hierarchy of Linux threads and their status (RUNNING, SYSCALL, IRQ, IDLE)."

  • How is thread status shown? "Show [...] their status (RUNNING, SYSCALL, IRQ, IDLE)" implies that there would be chart elements labelled with those states.

image

XY Chart

CPU Usage

Description: "Show the CPU usage of a Linux kernel trace, returns the CPU usage per process and can be filtered by CPU core"

  • What is the line that is shown by default? No checkboxes are checked.

image

Disk I/O View

Description: "Show the input and output throughput for each drive on a machine"

image

Histogram

Description: "Show a histogram of number of events to time for a trace"

image

Flame Chart

Description: "Show a call stack over time"

  • Displays as empty for certain traces (ex. lttng-userspace-tracing). Is this because events are missing? Because the chart isn't implemented yet?

image

Originally posted by @ebugden in #296 (comment)

@MatthewKhouzam
Copy link
Contributor Author

This should be a new issue, I think.

@MatthewKhouzam
Copy link
Contributor Author

Resources Status

Description: "Show the state of CPUs (SYSCALL, RUNNING, IRQ, SOFT_IRQ or IDLE) and its IRQs/SOFT_IRQs as well as its frequency."

How is the state of CPUs shown? The description "Show the state of CPUs (SYSCALL, RUNNING, IRQ," etc. implies that there would be chart elements labelled with those states

A given row is the an aspect of the state of the CPU.

This view also includes process/thread information?
It is there. (color = process/thread)

I think the main issue is we have an alignment bug in chrome.

I will answer the rest in deferred time.

@MatthewKhouzam
Copy link
Contributor Author

Does bar colour mean something?

The state. If a color repeats it is probably the same state. We have a limited palette so color re-use occurs.

Does bar width mean something?

Width = duration
Height = either the state, there are height differences to help red-green colorblind users. IRQs are less high than userspace.
For frequency, higher = moar megahurts.

@MatthewKhouzam
Copy link
Contributor Author

I would note, most of the issues you bring up are solved with the legend that is not yet part of the theia front end.

@ebugden ebugden changed the title Here is a list of core elements or information that are missing from certain chart types or views that make it difficult (or impossible) to use the results of the analysis. In some cases, this makes the view non-functional in practice. Related issues shown next to comment. Missing chart elements Aug 2, 2021
@ebugden ebugden added this to the MVP milestone Aug 2, 2021
@ebugden ebugden modified the milestones: MVP, 1.0 Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants