Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{tools}[GCCcore/12.2.0] datalad v0.18.4 #18675

Merged

Conversation

jkuhl-uni
Copy link
Contributor

@jkuhl-uni jkuhl-uni commented Aug 29, 2023

@jkuhl-uni
Copy link
Contributor Author

Hey @smoors,
could you please have a look at this again? Seems like the tests finally work :)

@easybuilders easybuilders deleted a comment from boegelbot Sep 28, 2023
@easybuilders easybuilders deleted a comment from boegelbot Sep 28, 2023
@easybuilders easybuilders deleted a comment from boegelbot Sep 28, 2023
@easybuilders easybuilders deleted a comment from boegelbot Sep 28, 2023
@smoors smoors changed the title adding easyconfigs: datalad-0.18.4-GCCcore-12.2.0.eb {tools}[GCCcore/12.2.0] datalad v0.18.4 Sep 28, 2023
@jkuhl-uni
Copy link
Contributor Author

Done, anything else?

@smoors
Copy link
Contributor

smoors commented Oct 10, 2023

Done, anything else?

can you also explain why Rust is needed?

@jkuhl-uni
Copy link
Contributor Author

Hey there, I'm sorry it took that long, but it seems like it works without Rust as a dep or as a builddep.

@smoors
Copy link
Contributor

smoors commented Nov 7, 2023

@boegelbot: please test @ generoso

@boegelbot
Copy link
Collaborator

@smoors: Request for testing this PR well received on login1

PR test command 'EB_PR=18675 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_18675 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 12120

Test results coming soon (I hope)...

- notification for comment with ID 1799785458 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
FAILED
Build succeeded for 0 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/eaa7763f73fe604932cb2ad9b5cc9637 for a full test report.

jkuhl-uni and others added 3 commits November 7, 2023 21:33
@jkuhl-uni
Copy link
Contributor Author

Hi, with all the changes, now python cannot import patool any more. I think that was why I used the source templates in the first place... I just changed the gitlab extension in the same way, but I think it has the same problem.
If you run python3 -c "import patoolib" and python3 -c "import gitlab" it should work :)

@smoors
Copy link
Contributor

smoors commented Nov 7, 2023

Hi, with all the changes, now python cannot import patool any more. I think that was why I used the source templates in the first place... I just changed the gitlab extension in the same way, but I think it has the same problem. If you run python3 -c "import patoolib" and python3 -c "import gitlab" it should work :)

in that case you should add a custom modulename e.g.:
'modulename': 'patoolib',

@jkuhl-uni
Copy link
Contributor Author

Thanks, I was not aware of that option

@jkuhl-uni
Copy link
Contributor Author

Works for me, thank you for your help!

@smoors smoors added the new label Nov 8, 2023
@smoors
Copy link
Contributor

smoors commented Nov 8, 2023

@boegelbot: please test @ generoso

@boegelbot
Copy link
Collaborator

@smoors: Request for testing this PR well received on login1

PR test command 'EB_PR=18675 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_18675 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 12121

Test results coming soon (I hope)...

- notification for comment with ID 1801280577 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/80b44c76e8bb34f3df2f0a37c6d0180c for a full test report.

@smoors
Copy link
Contributor

smoors commented Nov 8, 2023

@boegelbot please test @ jsc-zen2

@boegelbot
Copy link
Collaborator

@smoors: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=18675 EB_ARGS= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --mem-per-cpu=4000M --job-name test_PR_18675 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 3695

Test results coming soon (I hope)...

- notification for comment with ID 1801402002 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/boegelbot/7d0d0face8e35b17e2f4b391d5e7a4b7 for a full test report.

@smoors smoors added this to the next release (4.9.0?) milestone Nov 8, 2023
Copy link
Contributor

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smoors
Copy link
Contributor

smoors commented Nov 8, 2023

Going in, thanks @jkuhl-uni!

@smoors smoors merged commit 259a6d2 into easybuilders:develop Nov 8, 2023
9 checks passed
@jkuhl-uni jkuhl-uni deleted the 20230829093748_new_pr_datalad0184 branch December 14, 2023 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants