Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{base}[GCCcore/12.2.0] git-annex v10.20230802 #18673

Merged

Conversation

jkuhl-uni
Copy link
Contributor

@jkuhl-uni jkuhl-uni commented Aug 29, 2023

Hi there, this is a module providing git-annex. This will be useful together with my other PRs

to build Datalad.

@smoors smoors changed the title adding easyconfigs: git-annex-10.20230802-GCCcore-12.2.0.eb {base}[GCCcore/12.2.0] git-annex v10.20230802 Sep 1, 2023
Copy link
Contributor

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix formatting: don't use tabs, and 4 spaces per indent.

@jkuhl-uni
Copy link
Contributor Author

Hi, I understand the error, I just want to raise the issue that easybuild 4.8.0 (at least on our cluster) does not seem to check this, which is why I was not aware of this problem.

@jkuhl-uni
Copy link
Contributor Author

I think at least parts of the errors I am getting are coming from this.
@smoors can you tell me what is going on here?

Hi, I understand the error, I just want to raise the issue that easybuild 4.8.0 (at least on our cluster) does not seem to check this, which is why I was not aware of this problem.

@jkuhl-uni
Copy link
Contributor Author

Hi @smoors,
could you have a look if this is ready to merge so I could proceed with #18645?
I would be more than greatful.

@easybuilders easybuilders deleted a comment from boegelbot Sep 7, 2023
@easybuilders easybuilders deleted a comment from boegelbot Sep 7, 2023
@easybuilders easybuilders deleted a comment from boegelbot Sep 7, 2023
@easybuilders easybuilders deleted a comment from boegelbot Sep 7, 2023
@smoors smoors added the new label Sep 7, 2023
Co-authored-by: Sam Moors <smoors@users.noreply.github.com>
@smoors
Copy link
Contributor

smoors commented Sep 7, 2023

@boegelbot: please test @ generoso

@boegelbot
Copy link
Collaborator

@smoors: Request for testing this PR well received on login1

PR test command 'EB_PR=18673 EB_ARGS= EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_18673 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 11663

Test results coming soon (I hope)...

- notification for comment with ID 1710294803 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
FAILED
Build succeeded for 0 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/1f5d6de9d72a4454495e58ef3180702c for a full test report.

@jkuhl-uni
Copy link
Contributor Author

Okay, checksum does not match... I'll have a look again. I think I know what is going on, I think I forgiot the checkout of the correct tag when computing the given checksum.
Sorry about that

@smoors
Copy link
Contributor

smoors commented Sep 7, 2023

you don't have to manually insert the checksum, use eb <easyconfig> --force --inject-checksums

@jkuhl-uni
Copy link
Contributor Author

Thanks, yes. I did that.

Co-authored-by: Sam Moors <smoors@users.noreply.github.com>
@smoors
Copy link
Contributor

smoors commented Sep 7, 2023

@boegelbot: please test @ generoso

@boegelbot
Copy link
Collaborator

@smoors: Request for testing this PR well received on login1

PR test command 'EB_PR=18673 EB_ARGS= EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_18673 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 11664

Test results coming soon (I hope)...

- notification for comment with ID 1710353486 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/32856e8b73bc24671d4009bb31c32d89 for a full test report.

@smoors
Copy link
Contributor

smoors commented Sep 11, 2023

@boegelbot please test @ jsc-zen2

@boegelbot
Copy link
Collaborator

@smoors: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=18673 EB_ARGS= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --mem-per-cpu=4000M --job-name test_PR_18673 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 3358

Test results coming soon (I hope)...

- notification for comment with ID 1714093266 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/boegelbot/1262fb986d0a1e0b3751ae6b3ba81284 for a full test report.

@smoors smoors added this to the next release (4.8.2?) milestone Sep 11, 2023
Copy link
Contributor

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smoors
Copy link
Contributor

smoors commented Sep 11, 2023

Going in, thanks @jkuhl-uni!

@smoors smoors merged commit f6cf9da into easybuilders:develop Sep 11, 2023
@jkuhl-uni jkuhl-uni deleted the 20230829093329_new_pr_git-annex1020230802 branch September 21, 2023 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants