Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace HDF5 v1.13.1 with v1.12.2 as dependency, since we shouldn't use odd minor versions of HDF5 which are not stable releases #16153

Merged
merged 7 commits into from
Sep 1, 2022

Conversation

Micket
Copy link
Contributor

@Micket Micket commented Aug 29, 2022

(created using eb --new-pr)
Odd releases are just RCs apparently.

@Micket Micket added the update label Aug 29, 2022
@Micket Micket added this to the next release (4.6.1?) milestone Aug 29, 2022
@Micket
Copy link
Contributor Author

Micket commented Aug 29, 2022

I also dropped the dap4 tests for netCDF as they were previously failing for me while trying to access online resources. Even if that site is back, i don't think we want to rely on tests that access internet as I imagine it causes annoying failures for those building on internet-less nodes.

@Micket
Copy link
Contributor Author

Micket commented Aug 29, 2022

This is so inconveniently big, I'll do test reports in batches

@Micket
Copy link
Contributor Author

Micket commented Aug 29, 2022

Test report by @Micket
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in total)
alvis-c1 - Linux Rocky Linux 8.5, x86_64, Intel Xeon Processor (Skylake), Python 3.6.8
See https://gist.github.com/a63e51d61d2f289cb1ecfd2e3e01feeb for a full test report.

@Micket
Copy link
Contributor Author

Micket commented Aug 29, 2022

@boegel asked me to merge the test issue with netCDF first, so #16158

I'll rebase this PR once it's merged.

@Micket
Copy link
Contributor Author

Micket commented Aug 30, 2022

Test report by @Micket
SUCCESS
Build succeeded for 5 out of 5 (5 easyconfigs in total)
alvis-c1 - Linux Rocky Linux 8.5, x86_64, Intel Xeon Processor (Skylake), Python 3.6.8
See https://gist.github.com/78244561608cc83014401b1281037a65 for a full test report.

@Micket
Copy link
Contributor Author

Micket commented Aug 30, 2022

Test report by @Micket
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
alvis-c1 - Linux Rocky Linux 8.5, x86_64, Intel Xeon Processor (Skylake), Python 3.6.8
See https://gist.github.com/a3f2ac63488c6442e06dba0f75583f60 for a full test report.

@Micket
Copy link
Contributor Author

Micket commented Aug 30, 2022

Test report by @Micket
SUCCESS
Build succeeded for 6 out of 6 (2 easyconfigs in total)
alvis-c1 - Linux Rocky Linux 8.5, x86_64, Intel Xeon Processor (Skylake), Python 3.6.8
See https://gist.github.com/b8116014979ef017786a74bd00b857ec for a full test report.

@Micket
Copy link
Contributor Author

Micket commented Aug 30, 2022

Test report by @Micket
FAILED
Build succeeded for 0 out of 1 (1 easyconfigs in total)
alvis-c1 - Linux Rocky Linux 8.5, x86_64, Intel Xeon Processor (Skylake), Python 3.6.8
See https://gist.github.com/e58f956f4b1016fddc615335c4d2c338 for a full test report.

edit: I think this fail was because i managed to have built some dependency with Icelake arch in my test tree and this was a skylake node i tested from. Ugh.

@boegel boegel changed the title Drop HDF5 from 1.13.1 to 1.12.2 replace HDF5 v1.13.1 with v1.12.1 as dependency, since we shouldn't use odd minor versions of HDF5 which are not stable releases Aug 31, 2022
@boegel
Copy link
Member

boegel commented Aug 31, 2022

@boegelbot please test @ generoso
CORE_CNT=16

Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=16153 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_16153 --ntasks="16" ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 9096

Test results coming soon (I hope)...

- notification for comment with ID 1233335706 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@branfosj
Copy link
Member

Test report by @branfosj
SUCCESS
Build succeeded for 16 out of 16 (9 easyconfigs in total)
bear-pg0105u36b.bear.cluster - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Platinum 8360Y CPU @ 2.40GHz (icelake), Python 3.6.8
See https://gist.github.com/02ab685f4f346ef73c4475ec830b8671 for a full test report.

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 12 out of 12 (9 easyconfigs in total)
cnx1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2690 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/6828632f9d8949a083e5c995ce6b185e for a full test report.

@boegel
Copy link
Member

boegel commented Sep 1, 2022

Test report by @boegel
SUCCESS
Build succeeded for 9 out of 9 (9 easyconfigs in total)
node3100.skitty.os - Linux RHEL 8.4, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/c2cbfd9f774654bb8f69a8e7792b488e for a full test report.

@boegel
Copy link
Member

boegel commented Sep 1, 2022

Going in, thanks @Micket!

@boegel boegel merged commit f07968e into easybuilders:develop Sep 1, 2022
@jfgrimm jfgrimm changed the title replace HDF5 v1.13.1 with v1.12.1 as dependency, since we shouldn't use odd minor versions of HDF5 which are not stable releases replace HDF5 v1.13.1 with v1.12.2 as dependency, since we shouldn't use odd minor versions of HDF5 which are not stable releases Sep 1, 2022
@jfgrimm
Copy link
Member

jfgrimm commented Sep 28, 2022

@smoors
Copy link
Contributor

smoors commented Dec 22, 2022

@boegelbot please test @ jsc-zen2

@boegelbot
Copy link
Collaborator

@smoors: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=16153 EB_ARGS= /opt/software/slurm/bin/sbatch --mem-per-cpu=4000M --job-name test_PR_16153 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 1960

Test results coming soon (I hope)...

- notification for comment with ID 1363247366 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
FAILED
Build succeeded for 8 out of 10 (9 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/22170949e47985462f0035c0699e6f86 for a full test report.

@Micket Micket deleted the 20220829133002_new_pr_h5py370 branch April 21, 2023 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants