Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lack of optimisation for SHAPEIT4 v4.1.3 #12206

Merged

Conversation

verdurin
Copy link
Member

(created using eb --new-pr)

@verdurin verdurin changed the title Fix lack of optimisation {bio}[foss/2019b] SHAPEIT4 v4.1.3 - Fix lack of optimisation Feb 19, 2021
@verdurin
Copy link
Member Author

Fixes issue #12204

@verdurin verdurin added this to the next release (4.3.3?) milestone Feb 19, 2021
@verdurin
Copy link
Member Author

Test report by @verdurin
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
easybuild-c7.novalocal - Linux centos linux 7.9.2009, x86_64, Intel Xeon Processor (Skylake, IBRS), Python 3.6.8
See https://gist.github.com/e0e6ab91bfbffdae662f355e297b80ac for a full test report.

Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@verdurin I think we can avoid a patch file here by just using buildopts, see also #12207

@verdurin
Copy link
Member Author

@boegel I think we still need to patch out hard-coded HTSlib versions etc.

@boegel
Copy link
Member

boegel commented Feb 19, 2021

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3501.doduo.os - Linux RHEL 8.2, x86_64, AMD EPYC 7552 48-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/cde9356413305ee657c78714e297d584 for a full test report.

@boegel
Copy link
Member

boegel commented Feb 19, 2021

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on generoso

PR test command 'EB_PR=12206 EB_ARGS= /apps/slurm/default/bin/sbatch --job-name test_PR_12206 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 13884

Test results coming soon (I hope)...

- notification for comment with ID 782256095 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
generoso-c1-s-1 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/b10b582b0ddc0b2197ec41f27df4b5c2 for a full test report.

@boegel
Copy link
Member

boegel commented Feb 19, 2021

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3101.skitty.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 3.6.8
See https://gist.github.com/4d2491d1ea46f8979c7b6c762508d4cc for a full test report.

@boegel boegel changed the title {bio}[foss/2019b] SHAPEIT4 v4.1.3 - Fix lack of optimisation Fix lack of optimisation for SHAPEIT4 v4.1.3 Feb 19, 2021
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Member

boegel commented Feb 19, 2021

Going in, thanks @verdurin!

@boegel boegel merged commit a2e3cdc into easybuilders:develop Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants