Fix lack of optimisation for SHAPEIT4 v4.2.0 #12207
Conversation
verdurin
changed the title
|
Fixes issue #12204 |
|
Test report by @verdurin |
|
|
||
| #Best performance is achieved with this. Use it if running on the same plateform you're compiling. | ||
| -#CXXFLAG=-O3 -march=native | ||
| +CXXFLAG=-O3 -march=native |
There was a problem hiding this comment.
Shouldn't we rather set it to whatever the CXXFLAGS environment variable is? I.e.
CXXFLAG=${CXXFLAGS}
There was a problem hiding this comment.
@Micket would the same apply to LDFLAG?
There was a problem hiding this comment.
Sure, probably wouldn't hurt (though it seems the compiler did pick up the library paths anyway via one of the environment variables since it worked).
There was a problem hiding this comment.
Yes, I agree, just do this via buildopts:
buildopts = 'CXX="$CXX" CXXFLAG="$CXXFLAGS" LDFLAG="$CXXFLAGS"'There was a problem hiding this comment.
Now done. I had to fix the original toolchainopts, which caused an error after using CXXFLAGS.
|
|
||
| #Best performance is achieved with this. Use it if running on the same plateform you're compiling. | ||
| -#CXXFLAG=-O3 -march=native | ||
| +CXXFLAG=-O3 -march=native |
There was a problem hiding this comment.
Yes, I agree, just do this via buildopts:
buildopts = 'CXX="$CXX" CXXFLAG="$CXXFLAGS" LDFLAG="$CXXFLAGS"'
|
Test report by @boegel |
|
Test report by @boegel |
|
Going in, thanks @verdurin! |
boegel
changed the title
(created using
eb --new-pr)