-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{data}[GCC/9.3.0,iccifort/2020.1.217] HDF5.Serial v1.10.6 #11155
{data}[GCC/9.3.0,iccifort/2020.1.217] HDF5.Serial v1.10.6 #11155
Conversation
Deleting files with wrong filenames
Deleting files with wrong filenames
Test report by @zao |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Serial builds of HDF5 should use HDF5
as package name. They can differentiate from other HDF5 builds by adding serial
as versionsuffix
. As an example, we have HDF5-1.8.17-GCC-5.4.0-2.26-serial.eb
@lexming no. That is contrary to what was discussed in the latest EB conference call, i.e. https://github.com/easybuilders/easybuild/wiki/Conference-call-notes-20200819. paging @boegel |
@lexming We discussed this extensively during the last EasyBuild conf call, and @mboisson pointed out. @mboisson raised the problem (rightfully so) that packages like Boost, HDF5, netCDF which have a small (and rarely actually used) MPI component cause other packages to be installed with an MPI toolchain, which doesn't make much sense. One example is After a fairly extensive discussion during the call we agreed to add easyconfigs like For future easyconfig versions, we can also rename the current |
@boegel thanks for the explanation. If part of the goal is to be able to load both the serial and parallel builds, then I agree with the multiple package names. |
Test report by @lexming |
Test report by @lexming |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The resulting build is identical to HDF5
v1.10.6 except for the MPI support.
LGTM
Test report by @zao |
|
Test report by @zao |
@mboisson I'm personally in favor of lowercase too, so let's change it? |
@mboisson @smoors We discussed about the introduction of serial packages in today's EB conf call and we will make a specific branch to gather all these PRs and properly test them. |
Changed target to easybuilders:dual_serial_mpi |
Now that we have a specific branch, we can change package names later on. Going in, thanks @mboisson ! |
(created using
eb --new-pr
)