Make threading an explicit option rather than relying on the MPI impl… #914
Conversation
…ementation (ParaStaion MPI can support both possibilities)
|
Resolves #795 |
| @@ -108,7 +117,7 @@ def build_step(self): | |||
| if self.toolchain.options['i8']: | |||
| cflags += " -DINTSIZE64" | |||
|
|
|||
| if not self.toolchain.mpi_family() in [toolchain.INTELMPI, toolchain.QLOGICMPI]: #@UndefinedVariable | |||
| if self.cfg['threadedmpi']: | |||
There was a problem hiding this comment.
@ocaisa this implies that for builds on top of OpenMPI (for example), threadedmpi = True must be now specified to obtain the same installation, so this should be something like:
if self.cfg['threadedmpi'] or if self.toolchain.mpi_family() not in [toolchain.INTELMPI, toolchain.QLOGICMPI]to ensure backward compatibility?
There was a problem hiding this comment.
Ok, but I'm pretty sure this wasn't working for people, to my eyes it's mostly there for OpenFOAM and threaded scotch does not work with OpenFOAM.
I'll set the default to true for OpenMPI (that's backwards compatibility for everything in the easyconfig repo) but personally I think this is probably not doing what people actually expect.
There was a problem hiding this comment.
How do I check a variable has been set in the easyconfig? I need to know if they have explicitly set the value to false in the easyconfig so I can ensure I only change the value to true when it's not defined there.
There was a problem hiding this comment.
@ocaisa you could use None as default value, and assume people will set it to False in the easyconfig?
and then check self.cfg['threadedmpi'] is None
there's no easy way to distinguish between a default value and the same value but specified by the easyconfig
|
Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1973/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
@boegel Tested with ParaStation MPI and Intel MPI, backwards compatibility is now there and the new logic works |
| cflags += " -DSCOTCH_PTHREAD" | ||
|
|
||
| # TODO For backwards compatability of v2.8.0 the following is necessary but could be removed on a major version upgrade | ||
| if self.cfg['threadedmpi'] is None and not self.toolchain.mpi_family() in [toolchain.INTELMPI, toolchain.QLOGICMPI]: |
There was a problem hiding this comment.
please change to not in:
and self.toolchain.mpi_family() not in [toolchain.INTELMPI, toolchain.QLOGICMPI]:
|
going in, thanks @ocaisa! |
…ementation (ParaStaion MPI can support both possibilities)