don't auto-enable use of -DSCOTCH_PTHREAD when using MPI library other than Intel MPI in SCOTCH easyblock

[Micket]

Should have been done for EB 3.0 according to the comment in the script. No need to convert any old easyconfigs back into the old behavior to try and preserve anything, because old behavior is bad; i'm pretty sure we want this.

cf. in easybuilders/easybuild-easyconfigs#17459 (comment)

Fixes #2972

[boegel]

see also discussion in #914

[Micket]

Test report by @Micket

Overview of tested easyconfigs (in order)

• SUCCESS SCOTCH-7.0.3-gompi-2023a.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
alvis-c1 - Linux Rocky Linux 8.8, x86_64, Intel Xeon Processor (Skylake), Python 3.6.8
See https://gist.github.com/Micket/62bc193be0f01073c29e9a32aafdbf75 for a full test report.

[Micket]

Test report by @Micket

Overview of tested easyconfigs (in order)

• SUCCESS SCOTCH-7.0.3-gompi-2022b.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
alvis-c1 - Linux Rocky Linux 8.8, x86_64, Intel Xeon Processor (Skylake), Python 3.6.8
See https://gist.github.com/Micket/5572fe430a4c18bcbb843d72bec2f962 for a full test report.

[casparvl]

Test report by @casparvl

Overview of tested easyconfigs (in order)

• SUCCESS SCOTCH-7.0.1-gompi-2022a.eb
• SUCCESS SCOTCH-7.0.1-iimpi-2022a.eb

Build succeeded for 2 out of 2 (2 easyconfigs in total)
tcn1.local.snellius.surf.nl - Linux RHEL 8.6, x86_64, AMD EPYC 7H12 64-Core Processor, Python 3.6.8
See https://gist.github.com/casparvl/d197eab2502ad7f5d56387d8295a92cd for a full test report.

[casparvl]

Lgtm! I'm just checking with other maintainers how the PRs that target 5.0 are handled, before I press the merge button. Want to make extra sure I don't create an unwanted situation where 5.0 stuff ends up in a 4.X release ;-)

[casparvl]

Ok, all good, I see this targets the 5.0.X branch. Good to go!