Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Clang easyblock to add support for building extra tools + leveraging hwloc and Z3 as optional dependencies #2310

Merged
merged 4 commits into from
Jan 16, 2021

Conversation

geimer
Copy link
Contributor

@geimer geimer commented Jan 15, 2021

Add support for building the extra Clang tools, and optionally configuring use of hwloc by the OpenMP runtime, and Z3 bei the Clang static analyzer.

Copy link
Member

@ocaisa ocaisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, might be a while before generoso can build and test this on the open easyconfig PR

ocaisa
ocaisa previously requested changes Jan 15, 2021
Copy link
Member

@ocaisa ocaisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment

easybuild/easyblocks/c/clang.py Outdated Show resolved Hide resolved
@boegel boegel dismissed ocaisa’s stale review January 16, 2021 10:44

requested change made

@boegel boegel changed the title Update Clang easyblock update Clang easyblock to add support for building extra tools + leveraging hwloc and Z3 as optional dependencies Jan 16, 2021
@boegel boegel added this to the next release (4.3.3?) milestone Jan 16, 2021
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Member

boegel commented Jan 16, 2021

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS Clang-6.0.1-GCC-6.4.0-2.28.eb
  • SUCCESS Clang-9.0.1-GCCcore-8.3.0.eb
  • SUCCESS Clang-11.0.0-GCCcore-9.3.0.eb

Build succeeded for 3 out of 3 (3 easyconfigs in total)
node2606.swalot.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/d6647eac4099662c5fe21d21288b2ded for a full test report.

@ocaisa ocaisa merged commit 9549ed4 into easybuilders:develop Jan 16, 2021
@boegel
Copy link
Member

boegel commented Jan 16, 2021

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS Clang-6.0.1-GCC-6.4.0-2.28.eb
  • SUCCESS Clang-8.0.0-GCCcore-8.2.0.eb
  • SUCCESS Clang-10.0.0-GCCcore-9.3.0.eb

Build succeeded for 3 out of 3 (3 easyconfigs in total)
node3136.skitty.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 3.6.8
See https://gist.github.com/daf600641cb99b7c905a7d355ed0615a for a full test report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants