Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21357] Remove TopicAttributes from public APIs and make it private in xmlparser #5085

Merged
merged 37 commits into from
Jul 30, 2024

Conversation

Mario-DL
Copy link
Member

@Mario-DL Mario-DL commented Jul 18, 2024

Description

This PR:

  • Removes TopicAttributes from public APIs in DDS and RTPS making usage of the new PublicationBuiltinTopicData and SubscriptionBuiltinTopicData.
  • Moves TopicAttributes to the private folder and namespace eprosima::fastdds::xmlparser.
  • Includes new get_*_buitin_topic_data() methods in DataReader and DataWriter
  • Refactors some internal APIs (EDP, BuiltinProtocols,...) so they match the naming chain in snake_case.
  • Includes an improvement in the discover server test to make it more resilient.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • NO: Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • NO: Changes are API compatible.
  • New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • N/A: If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@Mario-DL Mario-DL added this to the v3.0.0 milestone Jul 18, 2024
@Mario-DL Mario-DL added doc-pending Issue or PR which is pending to be documented and removed doc-pending Issue or PR which is pending to be documented labels Jul 18, 2024
@github-actions github-actions bot added the ci-pending PR which CI is running label Jul 20, 2024
@Mario-DL Mario-DL added the needs-review PR that is ready to be reviewed label Jul 20, 2024
@Mario-DL Mario-DL requested review from MiguelCompany and removed request for MiguelCompany July 23, 2024 08:09
@Mario-DL Mario-DL requested review from MiguelCompany and removed request for MiguelCompany July 23, 2024 14:31
@MiguelCompany MiguelCompany force-pushed the feature/21357 branch 4 times, most recently from b73d265 to 51077f2 Compare July 26, 2024 07:54
@MiguelCompany MiguelCompany requested review from MiguelCompany and removed request for MiguelCompany July 26, 2024 08:10
MiguelCompany
MiguelCompany previously approved these changes Jul 26, 2024
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@MiguelCompany MiguelCompany removed the needs-review PR that is ready to be reviewed label Jul 26, 2024
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany MiguelCompany requested review from MiguelCompany and removed request for MiguelCompany July 29, 2024 07:36
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany MiguelCompany requested review from MiguelCompany and removed request for MiguelCompany July 29, 2024 13:03
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany MiguelCompany added skip-ci Automatically pass CI and removed versions-pending ci-pending PR which CI is running labels Jul 30, 2024
@Mario-DL
Copy link
Member Author

@MiguelCompany commits LGTM

@MiguelCompany MiguelCompany requested review from MiguelCompany and removed request for MiguelCompany July 30, 2024 05:48
versions.md Show resolved Hide resolved
versions.md Show resolved Hide resolved
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@Mario-DL
Copy link
Member Author

LGTM, ci full passed in 4c3d06e

Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Full green CI on commit 4c3d06e.
  • Later changes are not modifying the code.

Ready to merge!

@MiguelCompany MiguelCompany merged commit 955828e into master Jul 30, 2024
3 checks passed
@MiguelCompany MiguelCompany deleted the feature/21357 branch July 30, 2024 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-ci Automatically pass CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants