Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[21301] Remove WriterProxyData from public APIs #5052

Merged
merged 27 commits into from
Jul 17, 2024
Merged

[21301] Remove WriterProxyData from public APIs #5052

merged 27 commits into from
Jul 17, 2024

Conversation

MiguelCompany
Copy link
Member

@MiguelCompany MiguelCompany commented Jul 10, 2024 •
edited by Mario-DL
Loading

Description

This PR makes WriterProxyData an implementation detail of the library.
Changes include:

  • Moving PublicationBuiltinTopicData from fastdds::dds:builtin to fastdds::dds
  • Extending PublicationBuiltinTopicData with additional fields to mimick those of WriterProxyData
  • Writer discovery callbacks changed to receive a reason and a PublicationBuiltinTopicData
  • Method fill_discovery_data_from_cdr_message now fills a PublicationBuiltinTopicData
  • Struct WriterDiscoveryInfo has been removed
  • WriterProxyData.hpp has been moved to src

Changes on related repos:

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • NO Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • NO Changes are API compatible.
  • New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@MiguelCompany MiguelCompany added this to the v3.0.0 milestone Jul 10, 2024
@github-actions github-actions bot added the ci-pending PR which CI is running label Jul 10, 2024
@MiguelCompany MiguelCompany requested review from richiprosima and removed request for richiprosima July 11, 2024 06:08
@MiguelCompany MiguelCompany force-pushed the feature/21301 branch 2 times, most recently from 40d818d to c448645 Compare July 11, 2024 07:16
@MiguelCompany MiguelCompany requested review from richiprosima and removed request for richiprosima July 11, 2024 07:17
@MiguelCompany MiguelCompany marked this pull request as ready for review July 11, 2024 08:06
@MiguelCompany MiguelCompany mentioned this pull request Jul 11, 2024
Merged
7 tasks
@MiguelCompany MiguelCompany requested review from elianalf and removed request for richiprosima July 11, 2024 09:50
@MiguelCompany MiguelCompany mentioned this pull request Jul 11, 2024
Merged
7 tasks
@MiguelCompany MiguelCompany changed the base branch from feature/21239 to master July 11, 2024 13:05
@MiguelCompany MiguelCompany requested review from elianalf and removed request for elianalf July 11, 2024 13:06
Mario-DL
Mario-DL requested changes Jul 12, 2024
View reviewed changes
Copy link
Member

@Mario-DL Mario-DL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job in this PR.
The commit stack is well organised and facilitates the reading.

Leaving some minor suggestions

include/fastdds/rtps/writer/WriterDiscoveryInfo.hpp Outdated Show resolved Hide resolved
include/fastdds/rtps/writer/WriterDiscoveryInfo.hpp Outdated Show resolved Hide resolved
include/fastdds/rtps/writer/WriterDiscoveryInfo.hpp Outdated Show resolved Hide resolved
include/fastdds/rtps/builtin/data/PublicationBuiltinTopicData.hpp Show resolved Hide resolved
include/fastdds/rtps/builtin/data/PublicationBuiltinTopicData.hpp Outdated Show resolved Hide resolved
@MiguelCompany MiguelCompany mentioned this pull request Jul 15, 2024
Merged
6 tasks
@MiguelCompany MiguelCompany requested review from Mario-DL and removed request for elianalf July 15, 2024 10:00
@MiguelCompany MiguelCompany mentioned this pull request Jul 15, 2024
Merged
5 tasks
@MiguelCompany MiguelCompany requested review from Mario-DL and removed request for Mario-DL July 15, 2024 11:20
Mario-DL
Mario-DL previously approved these changes Jul 15, 2024
View reviewed changes
Copy link
Member

@Mario-DL Mario-DL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@MiguelCompany
Refs #21301. Implement conversion method.
36e2390 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany
Refs #21301. Refactor matched_writer_add.
ef6cefe 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany
Refs #21301. Add guid to PublicationBuiltinTopicData.
123ae75 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany
Refs #21301. Add type_information to PublicationBuiltinTopicData.
7a2c19d 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany
Refs #21301. Use PublicationBuiltinTopicData on participant listeners.
097818b 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany
Refs #21301. Use PublicationBuiltinTopicData on fill_discovery_data_f…
e0d4412 
…rom_cdr_message.

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany
Refs #21301. Additional fields on PublicationBuiltinTopicData.
6cd433f 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany
Refs #21301. Move WriterProxyData.hpp to src.
a584122 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany
Refs #21301. Additional refactor on matched_writer_add.
6ee1ae3 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany
Refs #21301. Uncrustify.
f9ad5e5 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany
Refs #21301. Rename internal method to matched_writer_add_edp.
a6b334f 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany
Refs #21301. Refactor on ReaderListener.
bfab3b9 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany
Refs #21301. Remove reference on doxygen comment.
3b2fa23 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany
Refs #21301. Add participant_guid on PublicationBuiltinTopicData.
1ff131e 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany
Refs #21301. Fix build without security.
ab00d3a 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany
Refs #21301. Add missing groups to doxygen_modules.hpp.
63ef983 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany
Refs #21301. Rename enum to WriterDiscoveryStatus.
b1a9db6 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany
Refs #21301. Rename header to WriterDiscoveryStatus.hpp.
2ea58f1 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany
Refs #21301. Use fastcdr::string_255.
ea53906 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany
Refs #21301. Uncrustify.
c7450c8 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany
Update versions.md
f498b2b 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany MiguelCompany requested review from Mario-DL and removed request for Mario-DL July 16, 2024 13:20
@MiguelCompany MiguelCompany mentioned this pull request Jul 16, 2024
Merged
13 tasks
Mario-DL
Mario-DL approved these changes Jul 17, 2024
View reviewed changes
Copy link
Member

@Mario-DL Mario-DL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@Mario-DL Mario-DL added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels Jul 17, 2024
@MiguelCompany MiguelCompany merged commit b0eb813 into master Jul 17, 2024
17 checks passed
@MiguelCompany MiguelCompany deleted the feature/21301 branch July 17, 2024 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mario-DL Mario-DL Mario-DL approved these changes

Assignees
No one assigned
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@MiguelCompany @Mario-DL