Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21279] Examples refactor: Static EDP discovery #5047

Merged
merged 8 commits into from
Jul 18, 2024

Conversation

JesusPoderoso
Copy link
Contributor

@JesusPoderoso JesusPoderoso commented Jul 9, 2024

Description

This PR is part of a suite of PR which would make a refactor in the repository examples.
It is intended to apply to most of the examples, by making them homogeneous, more understandable, and more specific to the case they were meant to be.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • ❌ Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • ❌ Changes are API compatible.
  • New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • N/A If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@JesusPoderoso JesusPoderoso added this to the v3.0.0 milestone Jul 9, 2024
@JesusPoderoso JesusPoderoso self-assigned this Jul 9, 2024
@JesusPoderoso JesusPoderoso force-pushed the feature/example_refactor/static_edp_discovery branch from eb10de3 to 655b8c9 Compare July 15, 2024 11:11
@JesusPoderoso JesusPoderoso force-pushed the feature/example_refactor/static_edp_discovery branch from 655b8c9 to 780647f Compare July 15, 2024 11:12
@JesusPoderoso JesusPoderoso requested review from Mario-DL and removed request for Mario-DL July 15, 2024 11:12
@github-actions github-actions bot added the ci-pending PR which CI is running label Jul 15, 2024
@JesusPoderoso JesusPoderoso requested review from Mario-DL and removed request for Mario-DL July 15, 2024 13:01
Copy link
Member

@Mario-DL Mario-DL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The refactor looks nice.
Leaving some minor suggestions

examples/cpp/static_edp_discovery/CLIParser.hpp Outdated Show resolved Hide resolved
examples/cpp/static_edp_discovery/CLIParser.hpp Outdated Show resolved Hide resolved
examples/cpp/static_edp_discovery/PublisherApp.hpp Outdated Show resolved Hide resolved
examples/cpp/static_edp_discovery/SubscriberApp.hpp Outdated Show resolved Hide resolved
examples/cpp/static_edp_discovery/PublisherApp.hpp Outdated Show resolved Hide resolved
examples/cpp/static_edp_discovery/SubscriberApp.hpp Outdated Show resolved Hide resolved
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
@JesusPoderoso JesusPoderoso force-pushed the feature/example_refactor/static_edp_discovery branch from 4945c8c to 4548260 Compare July 17, 2024 06:59
@Mario-DL Mario-DL self-requested a review July 17, 2024 07:00
Copy link
Member

@Mario-DL Mario-DL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@Mario-DL Mario-DL added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels Jul 17, 2024
@EduPonz EduPonz merged commit ad17121 into master Jul 18, 2024
16 of 17 checks passed
@EduPonz EduPonz deleted the feature/example_refactor/static_edp_discovery branch July 18, 2024 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants