Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[21137] RTPS WriterHistory refactor #4966

Merged
merged 45 commits into from
Jun 27, 2024
Merged

[21137] RTPS WriterHistory refactor #4966

merged 45 commits into from
Jun 27, 2024

Conversation

MiguelCompany
Copy link
Member

@MiguelCompany MiguelCompany commented Jun 18, 2024 •
edited by EduPonz
Loading

Description

This PR changes the responsibility of managing the change and payload pools from the RTPSWriter to the WriterHistory

This PR depends on #4958 and must be merged after that one.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • ❌ Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • ❌ Changes are API compatible.
  • New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@MiguelCompany MiguelCompany added this to the v3.0.0 milestone Jun 18, 2024
@github-actions github-actions bot added the ci-pending PR which CI is running label Jun 18, 2024
@MiguelCompany MiguelCompany requested review from richiprosima and removed request for richiprosima June 19, 2024 06:40
@MiguelCompany MiguelCompany requested review from richiprosima and removed request for richiprosima June 19, 2024 08:31
@MiguelCompany MiguelCompany changed the title RTPS WriterHistory refactor [21137] RTPS WriterHistory refactor Jun 19, 2024
@MiguelCompany MiguelCompany requested review from richiprosima and removed request for richiprosima June 19, 2024 09:02
@MiguelCompany MiguelCompany force-pushed the feature/21082/history branch 3 times, most recently from 1af45c5 to b4e4ef8 Compare June 19, 2024 14:53
@MiguelCompany MiguelCompany requested review from EduPonz and removed request for richiprosima June 19, 2024 14:53
@MiguelCompany
Copy link
Member Author

@richiprosima Please test_3 discovery-server

EduPonz
EduPonz suggested changes Jun 25, 2024
View reviewed changes
include/fastdds/rtps/history/WriterHistory.h Outdated Show resolved Hide resolved
src/cpp/rtps/history/WriterHistory.cpp Outdated Show resolved Hide resolved
@MiguelCompany MiguelCompany changed the base branch from master to feature/21128 June 25, 2024 12:29
@EduPonz EduPonz self-requested a review June 26, 2024 08:45
EduPonz
EduPonz approved these changes Jun 26, 2024
View reviewed changes
Copy link

@EduPonz EduPonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI and versions.md update

@MiguelCompany MiguelCompany added the doc-pending Issue or PR which is pending to be documented label Jun 26, 2024
MiguelCompany and others added 18 commits June 27, 2024 07:23
@MiguelCompany @EduPonz
Refs #21082. Several methods to create writers removed.
6af2861 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany @EduPonz
Refs #21082. Move data sharing pool initialization to DataWriterImpl.
75fcd15 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany @EduPonz
Refs #21082. Refactor creation of rtps writer.
dfa7b83 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany @EduPonz
Refs #21082. Refactor PersistentWriter.
91e0e68 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany @EduPonz
Refs #21082. Remove constructors taking pools.
9e4f645 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany @EduPonz
Refs #21082. RTPSWriter does not handle pools.
7b30668 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany @EduPonz
Refs #21082. Add pool getters to WriterHistory.
10241f1 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany @EduPonz
Refs #21082. Remove pool references on StatexxxWriter.
72cee5b 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany @EduPonz
Refs #21082. Move pools from Endpoint to BaseReader.
835b145 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany @EduPonz
Refs #21082. Avoid accessing history attributes.
aa3ae1a 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany @EduPonz
Refs #21082. Fixes on SecurityManager.
aec5ad9 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany @EduPonz
Refs #21082. Fix build after rebase.
84c2c78 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany @EduPonz
Refs #21082. Please linters.
f66a095 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany @EduPonz
Refs #21082. Fix release order in WriterHistory destructor.
ced028c 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany @EduPonz
Refs #21082. Move datasharing pool initialization to RTPSWriter.
c79ba3c 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany @EduPonz
Refs #21082. Fix negative tests.
1eebb46 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany @EduPonz
Refs #21137. Apply review suggestions.
fe9a1af 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany @EduPonz
Refs #21137. Apply suggestions from code review
f614bb3 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

Co-authored-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com>
@EduPonz EduPonz removed the temporarily-blocked PR must be merged after another one label Jun 27, 2024
@EduPonz
Refs #21137. Add note to versions.md
89c4df5 
Signed-off-by: eduponz <eduardoponz@eprosima.com>
@EduPonz EduPonz self-requested a review June 27, 2024 05:35
@EduPonz EduPonz requested review from EduPonz and removed request for EduPonz June 27, 2024 08:08
@EduPonz EduPonz added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels Jun 27, 2024
@EduPonz EduPonz merged commit d3ca40c into master Jun 27, 2024
23 of 31 checks passed
@EduPonz EduPonz deleted the feature/21082/history branch June 27, 2024 13:21
@Mario-DL Mario-DL mentioned this pull request Jun 28, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EduPonz EduPonz Awaiting requested review from EduPonz

Assignees
No one assigned
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@MiguelCompany @EduPonz