Refs #21137. Apply review suggestions.

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
eProsima · Jun 26, 2024 · 9a741c2 · 9a741c2
1 parent df98382
commit 9a741c2
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 3 deletions.
diff --git a/include/fastdds/rtps/history/WriterHistory.hpp b/include/fastdds/rtps/history/WriterHistory.hpp
@@ -58,15 +58,30 @@ class WriterHistory : public rtps::History
 public:
 
     /**
-     * Constructor of the WriterHistory.
+     * @brief Construct a WriterHistory.
+     *
+     * @param att  Attributes configuring the WriterHistory.
      */
     FASTDDS_EXPORTED_API WriterHistory(
             const HistoryAttributes& att);
 
+    /**
+     * @brief Construct a WriterHistory with a custom payload pool.
+     *
+     * @param att           Attributes configuring the WriterHistory.
+     * @param payload_pool  Pool of payloads to be used by the WriterHistory.
+     */
     FASTDDS_EXPORTED_API WriterHistory(
             const HistoryAttributes& att,
             const std::shared_ptr<IPayloadPool>& payload_pool);
 
+    /**
+     * @brief Construct a WriterHistory with custom payload and change pools.
+     *
+     * @param att           Attributes configuring the WriterHistory.
+     * @param payload_pool  Pool of payloads to be used by the WriterHistory.
+     * @param change_pool   Pool of changes to be used by the WriterHistory.
+     */
     FASTDDS_EXPORTED_API WriterHistory(
             const HistoryAttributes& att,
             const std::shared_ptr<IPayloadPool>& payload_pool,

diff --git a/src/cpp/rtps/history/WriterHistory.cpp b/src/cpp/rtps/history/WriterHistory.cpp
@@ -87,10 +87,9 @@ WriterHistory::WriterHistory(
         const HistoryAttributes& att,
         const std::shared_ptr<IPayloadPool>& payload_pool)
     : History(att)
+    , change_pool_(std::make_shared<CacheChangePool>(PoolConfig::from_history_attributes(att)))
     , payload_pool_(payload_pool)
 {
-    PoolConfig cfg = PoolConfig::from_history_attributes(att);
-    change_pool_ = std::make_shared<CacheChangePool>(cfg);
 }
 
 WriterHistory::WriterHistory(