Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20709] Make rtps messages headers private #4657

Merged
merged 7 commits into from
May 24, 2024
Merged

[20709] Make rtps messages headers private #4657

merged 7 commits into from
May 24, 2024

Conversation

elianalf
Copy link
Contributor

@elianalf elianalf commented Apr 4, 2024 •
edited by EduPonz
Loading

Description

Make rtps messages headers private :

  • RTPSMessageGroup.h
  • RTPSMessageCreator.h
  • CDRMessage.h
  • CDRMessage.hpp -> CDRMessage.cpp

Related PR:

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • ❌ Changes are ABI compatible.
  • ❌ Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@elianalf elianalf added this to the v3.0.0 milestone Apr 4, 2024
@elianalf elianalf force-pushed the feature/make_private_rtps_messages branch from 274b31d to 635968e Compare April 4, 2024 12:43
@elianalf elianalf added the needs-review PR that is ready to be reviewed label Apr 4, 2024
@elianalf elianalf changed the title Make rtps messages headers private [20709] Make rtps messages headers private Apr 4, 2024
@elianalf elianalf force-pushed the feature/make_private_rtps_messages branch 2 times, most recently from 88527b5 to 02e9b57 Compare April 5, 2024 07:55
@elianalf elianalf changed the base branch from 3.0.x-devel to feature/typelookup-listeners-implementation April 5, 2024 07:56
This was referenced Apr 5, 2024
Merged
Merged
@adriancampo adriancampo force-pushed the feature/typelookup-listeners-implementation branch from 4e6bea8 to 27a861e Compare April 9, 2024 07:07
@richiware richiware force-pushed the feature/typelookup-listeners-implementation branch from 7a602df to b0e2e65 Compare April 9, 2024 10:00
Base automatically changed from feature/typelookup-listeners-implementation to 3.0.x-devel April 10, 2024 14:27
@EduPonz EduPonz force-pushed the 3.0.x-devel branch 3 times, most recently from 5148f5d to bd83bb2 Compare April 23, 2024 05:52
@elianalf elianalf force-pushed the feature/make_private_rtps_messages branch from 02e9b57 to a8ef6e5 Compare April 24, 2024 06:42
@EduPonz EduPonz force-pushed the 3.0.x-devel branch 2 times, most recently from 08ee62b to 623db82 Compare May 13, 2024 09:26
@EduPonz EduPonz deleted the branch master May 14, 2024 07:22
@EduPonz EduPonz closed this May 14, 2024
@EduPonz EduPonz reopened this May 14, 2024
@EduPonz EduPonz changed the base branch from 3.0.x-devel to master May 14, 2024 07:28
@elianalf elianalf force-pushed the feature/make_private_rtps_messages branch from a8ef6e5 to 379bc9e Compare May 14, 2024 13:25
@elianalf elianalf requested a review from EduPonz May 14, 2024 13:27
@github-actions github-actions bot added the ci-pending PR which CI is running label May 14, 2024
@elianalf elianalf removed the needs-review PR that is ready to be reviewed label May 21, 2024
@elianalf
Copy link
Contributor Author

@richiprosima test linux

@elianalf elianalf force-pushed the feature/make_private_rtps_messages branch from 86131c7 to 8ca5e27 Compare May 21, 2024 10:50
@elianalf elianalf requested a review from EduPonz May 21, 2024 10:59
@elianalf
Refs #20709: Apply suggestions
f5d116a 
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
@elianalf elianalf force-pushed the feature/make_private_rtps_messages branch from 8ca5e27 to f5d116a Compare May 21, 2024 12:27
@elianalf
Refs #20709: Fix compilation issue
745a751 
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
@elianalf elianalf requested review from EduPonz and removed request for EduPonz May 22, 2024 05:29
@elianalf elianalf force-pushed the feature/make_private_rtps_messages branch from 4867ee6 to 333b767 Compare May 22, 2024 13:39
@elianalf elianalf mentioned this pull request May 22, 2024
Merged
6 tasks
@elianalf
Refs #20709: Apply suggestions
d3abbcd 
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
@elianalf elianalf force-pushed the feature/make_private_rtps_messages branch from 333b767 to d3abbcd Compare May 22, 2024 14:28
@elianalf elianalf requested review from EduPonz and removed request for EduPonz May 22, 2024 15:27
@elianalf
Copy link
Contributor Author

@richiprosima test windows

@elianalf
Copy link
Contributor Author

@richiprosima please test_3 this

EduPonz
EduPonz reviewed May 23, 2024
View reviewed changes
src/cpp/fastdds/core/policy/ParameterList.hpp Show resolved Hide resolved
src/cpp/rtps/messages/CDRMessage.cpp Outdated Show resolved Hide resolved
src/cpp/security/authentication/PKIDH.cpp Outdated Show resolved Hide resolved
EduPonz
EduPonz suggested changes May 23, 2024
View reviewed changes
Copy link

@EduPonz EduPonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor NITs. There are some still open points as well

@elianalf
Refs #20709: Order headers
6481ed8 
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
@elianalf elianalf force-pushed the feature/make_private_rtps_messages branch from 6a69ea3 to 6481ed8 Compare May 23, 2024 14:47
@elianalf elianalf requested a review from EduPonz May 23, 2024 14:47
@elianalf
Copy link
Contributor Author

@richiprosima please test_3 this

@EduPonz EduPonz added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels May 24, 2024
@EduPonz EduPonz merged commit c521caf into master May 24, 2024
11 of 15 checks passed
@EduPonz EduPonz deleted the feature/make_private_rtps_messages branch May 24, 2024 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EduPonz EduPonz EduPonz approved these changes

Assignees
No one assigned
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@elianalf @EduPonz