Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20709] Remove rtps messages headers made private #117

Merged
merged 1 commit into from
May 24, 2024
Merged

[20709] Remove rtps messages headers made private #117

merged 1 commit into from
May 24, 2024

Conversation

elianalf
Copy link
Contributor

@elianalf elianalf commented Apr 5, 2024 •
edited by EduPonz
Loading

Description

Remove rtps messages headers made private in related PR in Fast DDS:

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Changes are API compatible.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@elianalf elianalf mentioned this pull request Apr 5, 2024
Merged
7 tasks
Base automatically changed from 3.0.x-devel to main May 14, 2024 07:17
@elianalf
Refs #20709: remove rtps messages headers made private
0a755ac 
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
@elianalf elianalf force-pushed the feature/make_private_rtps_messages branch from d3fb166 to 0a755ac Compare May 21, 2024 09:08
@EduPonz EduPonz added the ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. label May 24, 2024
@EduPonz EduPonz merged commit 7ab8aa0 into main May 24, 2024
4 checks passed
@EduPonz EduPonz deleted the feature/make_private_rtps_messages branch May 24, 2024 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EduPonz EduPonz EduPonz approved these changes

Assignees
No one assigned
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elianalf @EduPonz