Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20542] Improve CI version management #4480

Merged
merged 9 commits into from
Mar 6, 2024
Merged

Conversation

JesusPoderoso
Copy link
Contributor

@JesusPoderoso JesusPoderoso commented Feb 29, 2024

Description

This PR unifies the CI in all workflows to follow this behavior:

  • Trigger CI in all pull requests which HEAD branch is set to this supported branch version
  • Remove any CI trigger on push events
  • Run nightly events in all supported branches as a matrix.
  • Include missing ignore files for the sanitizer event trigger.
  • Rename sanitizer job as "address-sanitizer"

The following PRs are the counterpart in the supported branches:

The follwing backports have been modified accoddingly:

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Changes are ABI compatible.
  • N/A Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

elianalf
elianalf previously approved these changes Mar 5, 2024
@JesusPoderoso
Copy link
Contributor Author

@richiprosima please test this

.github/workflows/nightly-windows-ci.yml Show resolved Hide resolved
.github/workflows/nightly-windows-ci.yml Show resolved Hide resolved
.github/workflows/nightly-ubuntu-ci.yml Show resolved Hide resolved
.github/workflows/nightly-mac-ci.yml Show resolved Hide resolved
.github/workflows/nightly-mac-ci.yml Show resolved Hide resolved
elianalf
elianalf previously approved these changes Mar 6, 2024
elianalf
elianalf previously approved these changes Mar 6, 2024
Copy link

@EduPonz EduPonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As agreed, please remove all push events

.github/workflows/documentation-tests.yaml Outdated Show resolved Hide resolved
.github/workflows/sanitizer-tests.yaml Outdated Show resolved Hide resolved
.github/workflows/thread-sanitizer.yaml Outdated Show resolved Hide resolved
EduPonz
EduPonz previously approved these changes Mar 6, 2024
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
@EduPonz EduPonz merged commit 13811f4 into master Mar 6, 2024
9 checks passed
@EduPonz EduPonz deleted the hotfix/ci_version_management branch March 6, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-ci Automatically pass CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants