[20019] Add Autofill port to TCP Transport #4061

cferreiragonz · 2023-11-28T14:32:21Z

Description

This PR allows to set listening ports of TCP transport to 0 in order to assign an available port automatically.

@Mergifyio backport 2.12.x 2.11.x 2.10.x 2.6.x

Contributor Checklist

Commit messages follow the project guidelines.
The code follows the style guidelines of this project.
Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
Any new/modified methods have been properly documented using Doxygen.
Changes are ABI compatible.
Changes are API compatible.
New feature has been added to the versions.md file (if applicable).
New feature has been documented/Current behavior is correctly described in the documentation.
Related documentation PR: Refs #20019: Add TCP listening port behavior when set to 0 Fast-DDS-docs#598 (PR)
Applicable backports have been included in the description.

Reviewer Checklist

The PR has a milestone assigned.
Check contributor checklist is correct.
Check CI results: changes do not issue any warning.
Check CI results: failing tests are unrelated with the changes.

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> Rearrange update of port Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

cferreiragonz · 2023-11-29T07:16:33Z

@richiprosima please test this

src/cpp/rtps/transport/TCPAcceptor.cpp

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

cferreiragonz · 2023-11-30T08:39:03Z

@richiprosima please test this

cferreiragonz · 2023-12-05T09:35:36Z

@Mergifyio backport 2.12.x 2.11.x 2.10.x 2.6.x

mergify · 2023-12-05T09:35:44Z

backport 2.12.x 2.11.x 2.10.x 2.6.x

✅ Backports have been created

#4101 [20019] Add Autofill port to TCP Transport (backport #4061) has been created for branch 2.12.x but encountered conflicts
#4102 [20019] Add Autofill port to TCP Transport (backport #4061) has been created for branch 2.11.x but encountered conflicts
#4103 [20019] Add Autofill port to TCP Transport (backport #4061) has been created for branch 2.10.x but encountered conflicts
#4104 [20019] Add Autofill port to TCP Transport (backport #4061) has been created for branch 2.6.x but encountered conflicts

* Refs #20019: Blackbox Test Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20019: Unittest autofill port Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20019: TCP Autofill port Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> Rearrange update of port Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20019: Uncrustify Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20019: Add static_cast conversion Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20019: Apply revision changes Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> --------- Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> (cherry picked from commit 36f31dd) # Conflicts: # src/cpp/rtps/transport/TCPAcceptor.cpp # test/blackbox/common/BlackboxTestsTransportTCP.cpp

* Refs #20019: Blackbox Test Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20019: Unittest autofill port Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20019: TCP Autofill port Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> Rearrange update of port Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20019: Uncrustify Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20019: Add static_cast conversion Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20019: Apply revision changes Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> --------- Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> (cherry picked from commit 36f31dd) # Conflicts: # src/cpp/rtps/transport/TCPAcceptor.cpp # test/blackbox/CMakeLists.txt # test/blackbox/common/BlackboxTestsTransportTCP.cpp

* Refs #20019: Blackbox Test Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20019: Unittest autofill port Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20019: TCP Autofill port Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> Rearrange update of port Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20019: Uncrustify Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20019: Add static_cast conversion Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20019: Apply revision changes Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> --------- Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> (cherry picked from commit 36f31dd) # Conflicts: # test/blackbox/common/BlackboxTestsTransportTCP.cpp Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>

* Add Autofill port to TCP Transport (#4061) * Refs #20019: Blackbox Test Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20019: Unittest autofill port Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20019: TCP Autofill port Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> Rearrange update of port Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20019: Uncrustify Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20019: Add static_cast conversion Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20019: Apply revision changes Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> --------- Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> (cherry picked from commit 36f31dd) # Conflicts: # src/cpp/rtps/transport/TCPAcceptor.cpp # test/blackbox/common/BlackboxTestsTransportTCP.cpp * Fix Conflicts Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> --------- Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> Co-authored-by: Carlos Ferreira González <carlosferreira@eprosima.com>

* Add Autofill port to TCP Transport (#4061) * Refs #20019: Blackbox Test Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20019: Unittest autofill port Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20019: TCP Autofill port Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> Rearrange update of port Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20019: Uncrustify Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20019: Add static_cast conversion Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20019: Apply revision changes Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> --------- Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> (cherry picked from commit 36f31dd) # Conflicts: # test/blackbox/common/BlackboxTestsTransportTCP.cpp Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com> * Fix conflicts Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com> --------- Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com> Co-authored-by: Carlos Ferreira González <carlosferreira@eprosima.com> Co-authored-by: elianalf <62831776+elianalf@users.noreply.github.com>

* Add Autofill port to TCP Transport (#4061) * Refs #20019: Blackbox Test Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20019: Unittest autofill port Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20019: TCP Autofill port Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> Rearrange update of port Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20019: Uncrustify Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20019: Add static_cast conversion Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20019: Apply revision changes Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> --------- Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> (cherry picked from commit 36f31dd) # Conflicts: # src/cpp/rtps/transport/TCPAcceptor.cpp # test/blackbox/CMakeLists.txt # test/blackbox/common/BlackboxTestsTransportTCP.cpp * Fix Conflicts Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> --------- Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> Co-authored-by: Carlos Ferreira González <carlosferreira@eprosima.com>

* Add Autofill port to TCP Transport (#4061) * Refs #20019: Blackbox Test Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20019: Unittest autofill port Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20019: TCP Autofill port Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> Rearrange update of port Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20019: Uncrustify Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20019: Add static_cast conversion Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20019: Apply revision changes Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> --------- Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> (cherry picked from commit 36f31dd) # Conflicts: # src/cpp/rtps/transport/TCPAcceptor.cpp # test/blackbox/common/BlackboxTestsTransportTCP.cpp * Fix Conflicts * Fix Conflicts --------- Co-authored-by: Carlos Ferreira González <carlosferreira@eprosima.com>

cferreiragonz added 4 commits November 28, 2023 15:26

Refs #20019: Blackbox Test

d42a69d

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

Refs #20019: Unittest autofill port

28fe3a7

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

Refs #20019: TCP Autofill port

261402c

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> Rearrange update of port Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

Refs #20019: Uncrustify

393598f

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

cferreiragonz added the needs-review PR that is ready to be reviewed label Nov 28, 2023

cferreiragonz requested review from MiguelCompany and elianalf and removed request for MiguelCompany November 28, 2023 14:32

cferreiragonz added this to the v2.13.0 milestone Nov 29, 2023

Refs #20019: Add static_cast conversion

895f04d

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

elianalf suggested changes Nov 29, 2023

View reviewed changes

src/cpp/rtps/transport/TCPAcceptor.cpp Show resolved Hide resolved

Refs #20019: Apply revision changes

7849563

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

elianalf approved these changes Nov 30, 2023

View reviewed changes

cferreiragonz added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed needs-review PR that is ready to be reviewed labels Dec 1, 2023

cferreiragonz mentioned this pull request Dec 1, 2023

Refs #20019: Add TCP listening port behavior when set to 0 eProsima/Fast-DDS-docs#598

Merged

MiguelCompany merged commit 36f31dd into master Dec 4, 2023
13 of 14 checks passed

MiguelCompany deleted the feature/autofill_port branch December 4, 2023 14:37

cferreiragonz removed the ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. label Dec 4, 2023

mergify bot mentioned this pull request Dec 5, 2023

[20019] Add Autofill port to TCP Transport (backport #4061) #4101

Merged

This was referenced Dec 5, 2023

[20019] Add Autofill port to TCP Transport (backport #4061) #4102

Merged

[20019] Add Autofill port to TCP Transport (backport #4061) #4103

Merged

mergify bot mentioned this pull request Dec 5, 2023

[20019] Add Autofill port to TCP Transport (backport #4061) #4104

Merged

EduPonz mentioned this pull request Dec 7, 2023

Fix Blackbox test's CMakeLists.txt #4060

Closed

7 tasks

JesusPoderoso mentioned this pull request Jan 15, 2024

TCP Transport always use 7410 as logic port #4186

Closed

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[20019] Add Autofill port to TCP Transport #4061

[20019] Add Autofill port to TCP Transport #4061

cferreiragonz commented Nov 28, 2023 •

edited

Loading

cferreiragonz commented Nov 29, 2023

cferreiragonz commented Nov 30, 2023

cferreiragonz commented Dec 5, 2023

mergify bot commented Dec 5, 2023 •

edited

Loading

[20019] Add Autofill port to TCP Transport #4061

[20019] Add Autofill port to TCP Transport #4061

Conversation

cferreiragonz commented Nov 28, 2023 • edited Loading

Description

Contributor Checklist

Reviewer Checklist

cferreiragonz commented Nov 29, 2023

cferreiragonz commented Nov 30, 2023

cferreiragonz commented Dec 5, 2023

mergify bot commented Dec 5, 2023 • edited Loading

✅ Backports have been created

cferreiragonz commented Nov 28, 2023 •

edited

Loading

mergify bot commented Dec 5, 2023 •

edited

Loading