Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refs #20019: Add TCP listening port behavior when set to 0 #598

Merged
merged 3 commits into from
Dec 4, 2023

Conversation

cferreiragonz
Copy link
Contributor

@cferreiragonz cferreiragonz commented Nov 29, 2023

Add behavior of TCP transport when listening port is set to 0.
Documentation for PR: eProsima/Fast-DDS#4061 (PR)

@Mergifyio backport 2.12.x 2.11.x 2.10.x 2.6.x

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
@elianalf
Copy link
Contributor

Everything clear, it may be needed to add the same information also in listening_port in the section 6.3.1 TCPTransportDescriptor https://eprosima-fast-rtps--598.org.readthedocs.build/en/598/fastdds/transport/tcp/tcp.html#tcptransportdescriptor

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
elianalf
elianalf previously approved these changes Nov 30, 2023
elianalf
elianalf previously approved these changes Dec 4, 2023
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
@MiguelCompany MiguelCompany merged commit 12cb668 into master Dec 4, 2023
4 checks passed
@MiguelCompany MiguelCompany deleted the feature/autofill_port branch December 4, 2023 14:37
@cferreiragonz
Copy link
Contributor Author

@Mergifyio backport 2.12.x 2.11.x 2.10.x 2.6.x

Copy link

mergify bot commented Dec 11, 2023

backport 2.12.x 2.11.x 2.10.x 2.6.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Dec 11, 2023
* Refs #20019: Add TCP listening port behavior when set to 0

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

* Refs #20019: Add info to 6.3.1 section

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

* Refs #20019: Update port of tcp use case

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

---------

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
(cherry picked from commit 12cb668)
mergify bot pushed a commit that referenced this pull request Dec 11, 2023
* Refs #20019: Add TCP listening port behavior when set to 0

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

* Refs #20019: Add info to 6.3.1 section

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

* Refs #20019: Update port of tcp use case

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

---------

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
(cherry picked from commit 12cb668)

# Conflicts:
#	code/DDSCodeTester.cpp
#	code/XMLTester.xml
mergify bot pushed a commit that referenced this pull request Dec 11, 2023
* Refs #20019: Add TCP listening port behavior when set to 0

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

* Refs #20019: Add info to 6.3.1 section

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

* Refs #20019: Update port of tcp use case

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

---------

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
(cherry picked from commit 12cb668)

# Conflicts:
#	code/DDSCodeTester.cpp
#	code/XMLTester.xml
mergify bot pushed a commit that referenced this pull request Dec 11, 2023
* Refs #20019: Add TCP listening port behavior when set to 0

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

* Refs #20019: Add info to 6.3.1 section

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

* Refs #20019: Update port of tcp use case

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

---------

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
(cherry picked from commit 12cb668)

# Conflicts:
#	code/DDSCodeTester.cpp
#	code/XMLTester.xml
EduPonz pushed a commit that referenced this pull request Dec 12, 2023
* Refs #20019: Add TCP listening port behavior when set to 0

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

* Refs #20019: Add info to 6.3.1 section

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

* Refs #20019: Update port of tcp use case

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

---------

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
(cherry picked from commit 12cb668)

Co-authored-by: Carlos Ferreira González <carlosferreira@eprosima.com>
cferreiragonz added a commit that referenced this pull request Dec 12, 2023
* Refs #20019: Add TCP listening port behavior when set to 0

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

* Refs #20019: Add info to 6.3.1 section

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

* Refs #20019: Update port of tcp use case

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

---------

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
(cherry picked from commit 12cb668)
cferreiragonz added a commit that referenced this pull request Dec 12, 2023
* Refs #20019: Add TCP listening port behavior when set to 0

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

* Refs #20019: Add info to 6.3.1 section

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

* Refs #20019: Update port of tcp use case

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

---------

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
(cherry picked from commit 12cb668)
cferreiragonz added a commit that referenced this pull request Dec 12, 2023
* Refs #20019: Add TCP listening port behavior when set to 0

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

* Refs #20019: Add info to 6.3.1 section

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

* Refs #20019: Update port of tcp use case

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

---------

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
(cherry picked from commit 12cb668)
cferreiragonz added a commit that referenced this pull request Dec 12, 2023
* Refs #20019: Add TCP listening port behavior when set to 0

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

* Refs #20019: Add info to 6.3.1 section

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

* Refs #20019: Update port of tcp use case

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

---------

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
(cherry picked from commit 12cb668)

Co-authored-by: Carlos Ferreira González <carlosferreira@eprosima.com>
cferreiragonz added a commit that referenced this pull request Dec 12, 2023
* Refs #20019: Add TCP listening port behavior when set to 0

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

* Refs #20019: Add info to 6.3.1 section

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

* Refs #20019: Update port of tcp use case

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

---------

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
(cherry picked from commit 12cb668)

Co-authored-by: Carlos Ferreira González <carlosferreira@eprosima.com>
cferreiragonz added a commit that referenced this pull request Dec 12, 2023
* Refs #20019: Add TCP listening port behavior when set to 0

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

* Refs #20019: Add info to 6.3.1 section

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

* Refs #20019: Update port of tcp use case

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

---------

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
(cherry picked from commit 12cb668)

Co-authored-by: Carlos Ferreira González <carlosferreira@eprosima.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants