Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[19048] Backport workflows from master #3965

Merged
merged 6 commits into from
Dec 1, 2023
Merged

[19048] Backport workflows from master #3965

merged 6 commits into from
Dec 1, 2023

Conversation

MiguelCompany
Copy link
Member

@MiguelCompany MiguelCompany commented Oct 27, 2023 •
edited
Loading

Description

This copies the github workflows folder from master.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@MiguelCompany MiguelCompany added this to the v2.6.7 milestone Oct 27, 2023
@MiguelCompany MiguelCompany changed the title [19048] Backport workflows from master. [19048] Backport workflows from master Oct 27, 2023
This was referenced Oct 27, 2023
Closed
Closed
@MiguelCompany
Refs #19048. Backport workflows from master.
cd0d361 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs #19048. Change discovery-server version.
138dbb9 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs #19048. Also backport actions.
442267d 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@JesusPoderoso
Copy link
Contributor

@richiprosima please test this

JesusPoderoso
JesusPoderoso reviewed Nov 28, 2023
View reviewed changes
.github/workflows/documentation-tests.yaml Outdated Show resolved Hide resolved
.github/workflows/nightly-windows-ci.yml Outdated Show resolved Hide resolved
.github/workflows/sanitizer-tests.yaml Outdated Show resolved Hide resolved
.github/workflows/thread-sanitizer.yaml Outdated Show resolved Hide resolved
.github/workflows/windows-ci.yml Outdated Show resolved Hide resolved
@EduPonz
Refs #19048: Cleanup actions
dcc3314 
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
@MiguelCompany MiguelCompany mentioned this pull request Nov 30, 2023
Merged
@EduPonz
Refs #19048: Apply Miguel's suggestions
bee5f0c 
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
MiguelCompany
MiguelCompany commented Dec 1, 2023
View reviewed changes
Copy link
Member Author

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green github CI

JesusPoderoso
JesusPoderoso requested changes Dec 1, 2023
View reviewed changes
.github/workflows/documentation-tests.yaml Outdated Show resolved Hide resolved
.github/workflows/documentation-tests.yaml Outdated Show resolved Hide resolved
.github/workflows/sanitizer-tests.yaml Outdated Show resolved Hide resolved
@EduPonz
Refs #19048: Apply Jesus' suggestions
7f5610d 
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
JesusPoderoso
JesusPoderoso approved these changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@JesusPoderoso JesusPoderoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green github CI

@MiguelCompany
Copy link
Member Author

I will go ahead and merge this, since the deadlock reported by tsan has not been introduced by this PR. We'll investigate it separately

@MiguelCompany MiguelCompany merged commit 19b015b into 2.6.x Dec 1, 2023
8 of 9 checks passed
@MiguelCompany MiguelCompany deleted the backport/workflows/2.6.x branch December 1, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EduPonz EduPonz EduPonz left review comments

@JesusPoderoso JesusPoderoso JesusPoderoso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.6.7
Development

Successfully merging this pull request may close these issues.
3 participants
@MiguelCompany @JesusPoderoso @EduPonz