Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the clang build for clang 14. (backport #3923) #3929

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 11, 2023

This is an automatic backport of pull request #3923 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

* Fix the clang build for clang 14.

clang 14 does not understand -Wno-deprecated-builtins,
which causes problems trying to compile Fast-DDS on
Ubuntu 22.04

Signed-off-by: Chris Lalancette <clalancette@gmail.com>

* Only add the flag for Clang 15 and newer.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>

---------

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
(cherry picked from commit 38820e9)
@mergify mergify bot mentioned this pull request Oct 11, 2023
7 tasks
@MiguelCompany MiguelCompany added the ci-pending PR which CI is running label Oct 11, 2023
@MiguelCompany MiguelCompany added this to the v2.6.7 milestone Oct 11, 2023
@MiguelCompany
Copy link
Member

@richiprosima please test mac

@JesusPoderoso JesusPoderoso added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels Oct 20, 2023
@EduPonz EduPonz merged commit 354b19f into 2.6.x Oct 24, 2023
6 checks passed
@EduPonz EduPonz deleted the mergify/bp/2.6.x/pr-3923 branch October 24, 2023 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants