Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the clang build for clang 14. #3923

Merged
merged 2 commits into from
Oct 11, 2023
Merged

Fix the clang build for clang 14. #3923

merged 2 commits into from
Oct 11, 2023

Conversation

clalancette
Copy link
Contributor

@clalancette clalancette commented Oct 10, 2023 •
edited by MiguelCompany
Loading

clang 14 does not understand -Wno-deprecated-builtins, which causes problems trying to compile Fast-DDS on Ubuntu 22.04

This has been causing ROS 2 CI to fail for a few days now: https://ci.ros2.org/view/nightly/job/nightly_linux_clang_libcxx/1669/

Description

Remove the unsupported -Wno-deprecated-builtins flag.

It may be the case that we want to port this to other branches as well; I leave it up to the maintainers to decide.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • [N/A] Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • [N/A] Any new/modified methods have been properly documented using Doxygen.
  • [N/A] Changes are ABI compatible.
  • [N/A] Changes are API compatible.
  • [N/A] New feature has been added to the versions.md file (if applicable).
  • [N/A ] New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@clalancette
Fix the clang build for clang 14.
f2c363a 
clang 14 does not understand -Wno-deprecated-builtins,
which causes problems trying to compile Fast-DDS on
Ubuntu 22.04

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
MiguelCompany
MiguelCompany requested changes Oct 11, 2023
View reviewed changes
CMakeLists.txt Show resolved Hide resolved
@clalancette
Only add the flag for Clang 15 and newer.
17a0a6f 
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
@MiguelCompany MiguelCompany added the no-test Skip CI tests if PR marked with this label label Oct 11, 2023
@MiguelCompany
Copy link
Member

@richiprosima Please test this

@MiguelCompany MiguelCompany added the ci-pending PR which CI is running label Oct 11, 2023
MiguelCompany
MiguelCompany approved these changes Oct 11, 2023
View reviewed changes
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if it builds ok in CI

@MiguelCompany MiguelCompany added this to the v2.11.3 milestone Oct 11, 2023
@MiguelCompany
Copy link
Member

@Mergifyio backport master 2.10.x 2.6.x

@mergify
Copy link
Contributor

mergify bot commented Oct 11, 2023 •
edited
Loading

backport master 2.10.x 2.6.x

✅ Backports have been created

@MiguelCompany
Copy link
Member

@richiprosima Please test mac

@MiguelCompany MiguelCompany merged commit 38820e9 into eProsima:2.11.x Oct 11, 2023
8 of 12 checks passed
@MiguelCompany
Copy link
Member

@clalancette Thanks!

mergify bot pushed a commit that referenced this pull request Oct 11, 2023
@clalancette @mergify
Fix the clang build for clang 14 (#3923)
56693c7 
* Fix the clang build for clang 14.

clang 14 does not understand -Wno-deprecated-builtins,
which causes problems trying to compile Fast-DDS on
Ubuntu 22.04

Signed-off-by: Chris Lalancette <clalancette@gmail.com>

* Only add the flag for Clang 15 and newer.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>

---------

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
(cherry picked from commit 38820e9)
@mergify mergify bot mentioned this pull request Oct 11, 2023
Merged
mergify bot pushed a commit that referenced this pull request Oct 11, 2023
@clalancette @mergify
Fix the clang build for clang 14 (#3923)
b1ab8a5 
* Fix the clang build for clang 14.

clang 14 does not understand -Wno-deprecated-builtins,
which causes problems trying to compile Fast-DDS on
Ubuntu 22.04

Signed-off-by: Chris Lalancette <clalancette@gmail.com>

* Only add the flag for Clang 15 and newer.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>

---------

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
(cherry picked from commit 38820e9)
@mergify mergify bot mentioned this pull request Oct 11, 2023
Merged
mergify bot pushed a commit that referenced this pull request Oct 11, 2023
@clalancette @mergify
Fix the clang build for clang 14 (#3923)
def4bab 
* Fix the clang build for clang 14.

clang 14 does not understand -Wno-deprecated-builtins,
which causes problems trying to compile Fast-DDS on
Ubuntu 22.04

Signed-off-by: Chris Lalancette <clalancette@gmail.com>

* Only add the flag for Clang 15 and newer.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>

---------

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
(cherry picked from commit 38820e9)
@mergify mergify bot mentioned this pull request Oct 11, 2023
Merged
@clalancette clalancette deleted the clalancette/fix-clang-build branch October 11, 2023 14:24
@clalancette
Copy link
Contributor Author

@clalancette Thanks!

Thanks for merging so quickly.

EduPonz pushed a commit that referenced this pull request Oct 24, 2023
@mergify @clalancette
Fix the clang build for clang 14 (#3923) (#3929)
354b19f 
* Fix the clang build for clang 14.

clang 14 does not understand -Wno-deprecated-builtins,
which causes problems trying to compile Fast-DDS on
Ubuntu 22.04

Signed-off-by: Chris Lalancette <clalancette@gmail.com>

* Only add the flag for Clang 15 and newer.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>

---------

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
(cherry picked from commit 38820e9)

Co-authored-by: Chris Lalancette <clalancette@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiguelCompany MiguelCompany MiguelCompany approved these changes

Assignees
No one assigned
Labels
ci-pending PR which CI is running no-test Skip CI tests if PR marked with this label
Projects
None yet
Milestone
v2.11.3
Development

Successfully merging this pull request may close these issues.
2 participants
@clalancette @MiguelCompany