Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build on old compilers when FASTDDS_STATISTICS is define #2929

Merged
merged 1 commit into from
Oct 11, 2022
Merged

Fix build on old compilers when FASTDDS_STATISTICS is define #2929

merged 1 commit into from
Oct 11, 2022

Conversation

tongtongdi
Copy link
Contributor

@tongtongdi tongtongdi commented Aug 26, 2022 •
edited
Loading

Fix build on old compilers when FASTDDS_STATISTICS is define same as #2220

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added.
  • Any new/modified methods have been properly documented using Doxygen.
  • Fast DDS test suite has been run locally.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • Documentation builds and tests pass locally.
  • New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.

Reviewer Checklist

  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

Fix build on old compilers when FASTDDS_STATISTICS is define
7d393eb 
Signed-off-by: wangtong <wangtong11@xiaomi.com>
@tongtongdi tongtongdi mentioned this pull request Aug 26, 2022
Closed
13 tasks
JLBuenoLopez
JLBuenoLopez approved these changes Aug 26, 2022
View reviewed changes
Copy link
Contributor

@JLBuenoLopez JLBuenoLopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks, @tongtongdi!

@MiguelCompany MiguelCompany merged commit a0b274a into eProsima:master Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JLBuenoLopez JLBuenoLopez JLBuenoLopez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tongtongdi @JLBuenoLopez @MiguelCompany