Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow fully qualified name on MemberDescriptor [13942] #2518

Merged
merged 3 commits into from
Feb 22, 2022
Merged

Allow fully qualified name on MemberDescriptor [13942] #2518

merged 3 commits into from
Feb 22, 2022

Conversation

MiguelCompany
Copy link
Member

No description provided.

@MiguelCompany
Refs 13938. Regression test.
2718061 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs 13938. Uncrustify.
fd9fab6 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs 13938. Fix issue.
d8114be 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany MiguelCompany added this to the v2.5.1 milestone Feb 22, 2022
@MiguelCompany MiguelCompany changed the title Allow fully qualified name on MemberDescriptor Allow fully qualified name on MemberDescriptor [13942] Feb 22, 2022
jsan-rt
jsan-rt approved these changes Feb 22, 2022
View reviewed changes
Copy link
Contributor

@jsan-rt jsan-rt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MiguelCompany MiguelCompany merged commit 4a3f919 into master Feb 22, 2022
@MiguelCompany MiguelCompany deleted the bugfix/13938 branch February 22, 2022 13:28
@MiguelCompany
Copy link
Member Author

@Mergifyio backport 2.4.x 2.3.x 2.1.x

mergify bot pushed a commit that referenced this pull request Feb 24, 2022
@MiguelCompany
Allow fully qualified name on MemberDescriptor (#2518)
efbcc3c 
* Refs 13938. Regression test.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 13938. Uncrustify.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 13938. Fix issue.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
(cherry picked from commit 4a3f919)
@mergify mergify bot mentioned this pull request Feb 24, 2022
Merged
mergify bot pushed a commit that referenced this pull request Feb 24, 2022
@MiguelCompany
Allow fully qualified name on MemberDescriptor (#2518)
4eacd93 
* Refs 13938. Regression test.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 13938. Uncrustify.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 13938. Fix issue.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
(cherry picked from commit 4a3f919)
@mergify mergify bot mentioned this pull request Feb 24, 2022
Merged
mergify bot pushed a commit that referenced this pull request Feb 24, 2022
@MiguelCompany
Allow fully qualified name on MemberDescriptor (#2518)
6817995 
* Refs 13938. Regression test.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 13938. Uncrustify.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 13938. Fix issue.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
(cherry picked from commit 4a3f919)
@mergify mergify bot mentioned this pull request Feb 24, 2022
Merged
@mergify
Copy link
Contributor

mergify bot commented Feb 24, 2022

backport 2.4.x 2.3.x 2.1.x

✅ Backports have been created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsan-rt jsan-rt jsan-rt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.5.1
Development

Successfully merging this pull request may close these issues.
2 participants
@MiguelCompany @jsan-rt