-
Notifications
You must be signed in to change notification settings - Fork 765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[13312] Added PrintTo function for null_type #2462
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>
Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>
MiguelCompany
approved these changes
Feb 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@Mergifyio backport 2.4.x 2.3.x 2.1.x |
mergify bot
pushed a commit
that referenced
this pull request
Feb 18, 2022
* Added workaround for GCC's incorrect GTest handling of null_types Signed-off-by: Javier Santiago <javiersantiago@eprosima.com> * Added GTest printer for dds::core::null_type Signed-off-by: Javier Santiago <javiersantiago@eprosima.com> (cherry picked from commit 53ac012)
mergify bot
pushed a commit
that referenced
this pull request
Feb 18, 2022
* Added workaround for GCC's incorrect GTest handling of null_types Signed-off-by: Javier Santiago <javiersantiago@eprosima.com> * Added GTest printer for dds::core::null_type Signed-off-by: Javier Santiago <javiersantiago@eprosima.com> (cherry picked from commit 53ac012) # Conflicts: # test/unittest/dds/participant/ParticipantTests.cpp
mergify bot
pushed a commit
that referenced
this pull request
Feb 18, 2022
* Added workaround for GCC's incorrect GTest handling of null_types Signed-off-by: Javier Santiago <javiersantiago@eprosima.com> * Added GTest printer for dds::core::null_type Signed-off-by: Javier Santiago <javiersantiago@eprosima.com> (cherry picked from commit 53ac012) # Conflicts: # test/unittest/dds/participant/ParticipantTests.cpp
✅ Backports have been created
|
MiguelCompany
pushed a commit
that referenced
this pull request
Feb 23, 2022
* Added PrintTo function for null_type (#2462) * Added workaround for GCC's incorrect GTest handling of null_types Signed-off-by: Javier Santiago <javiersantiago@eprosima.com> * Added GTest printer for dds::core::null_type Signed-off-by: Javier Santiago <javiersantiago@eprosima.com> (cherry picked from commit 53ac012) # Conflicts: # test/unittest/dds/participant/ParticipantTests.cpp * Fixed merge conflicts Signed-off-by: Javier Santiago <javiersantiago@eprosima.com> Co-authored-by: jsantiago-eProsima <90755661+jsantiago-eProsima@users.noreply.github.com> Co-authored-by: Javier Santiago <javiersantiago@eprosima.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Latest version of GTest complains because it cannot deduce how to print dds::core::null_type. This PR fixes this issue by creating an explicit PrintTo for GTest to use.