Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13312] Added PrintTo function for null_type #2462

Merged
merged 2 commits into from
Feb 18, 2022

Conversation

jsan-rt
Copy link
Contributor

@jsan-rt jsan-rt commented Feb 3, 2022

Latest version of GTest complains because it cannot deduce how to print dds::core::null_type. This PR fixes this issue by creating an explicit PrintTo for GTest to use.

Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>
Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>
@jsan-rt jsan-rt added this to the v2.6.0 milestone Feb 3, 2022
@MiguelCompany MiguelCompany modified the milestones: v2.6.0, v2.5.1 Feb 11, 2022
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MiguelCompany MiguelCompany merged commit 53ac012 into master Feb 18, 2022
@MiguelCompany MiguelCompany deleted the bugfix/gtest-gcc-fix branch February 18, 2022 07:49
@MiguelCompany
Copy link
Member

@Mergifyio backport 2.4.x 2.3.x 2.1.x

mergify bot pushed a commit that referenced this pull request Feb 18, 2022
* Added workaround for GCC's incorrect GTest handling of null_types

Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>

* Added GTest printer for dds::core::null_type

Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>
(cherry picked from commit 53ac012)
mergify bot pushed a commit that referenced this pull request Feb 18, 2022
* Added workaround for GCC's incorrect GTest handling of null_types

Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>

* Added GTest printer for dds::core::null_type

Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>
(cherry picked from commit 53ac012)

# Conflicts:
#	test/unittest/dds/participant/ParticipantTests.cpp
mergify bot pushed a commit that referenced this pull request Feb 18, 2022
* Added workaround for GCC's incorrect GTest handling of null_types

Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>

* Added GTest printer for dds::core::null_type

Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>
(cherry picked from commit 53ac012)

# Conflicts:
#	test/unittest/dds/participant/ParticipantTests.cpp
@mergify
Copy link
Contributor

mergify bot commented Feb 18, 2022

backport 2.4.x 2.3.x 2.1.x

✅ Backports have been created

MiguelCompany pushed a commit that referenced this pull request Feb 23, 2022
* Added PrintTo function for null_type (#2462)

* Added workaround for GCC's incorrect GTest handling of null_types

Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>

* Added GTest printer for dds::core::null_type

Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>
(cherry picked from commit 53ac012)

# Conflicts:
#	test/unittest/dds/participant/ParticipantTests.cpp

* Fixed merge conflicts

Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>

Co-authored-by: jsantiago-eProsima <90755661+jsantiago-eProsima@users.noreply.github.com>
Co-authored-by: Javier Santiago <javiersantiago@eprosima.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants