Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[21300] Remove ReaderProxyData from public APIs #167

Merged
merged 4 commits into from
Jul 18, 2024
Merged

[21300] Remove ReaderProxyData from public APIs #167

merged 4 commits into from
Jul 18, 2024

Conversation

MiguelCompany
Copy link
Member

@MiguelCompany MiguelCompany commented Jul 16, 2024 •
edited by Mario-DL
Loading

Description

This PR updates the python bindings to the changes introduced by eProsima/Fast-DDS#5078

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • NO Changes are API compatible.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@MiguelCompany MiguelCompany added this to the v2.0.0 milestone Jul 16, 2024
@MiguelCompany MiguelCompany mentioned this pull request Jul 16, 2024
Merged
13 tasks
Base automatically changed from feature/21301 to main July 17, 2024 05:59
@MiguelCompany
Refs #21300. Refactor SubscriptionBuiltinTopicData.
e834dbe 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany
Refs #21300. Additional fields on SubscriptionBuiltinTopicData.
ac7e5fb 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany
Refs #21300. Move ReaderProxyData.hpp to src.
a235122 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany
Refs #21300. Rename header to ReaderDiscoveryStatus.hpp.
a861a0d 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@Mario-DL Mario-DL self-requested a review July 17, 2024 15:55
@github-actions github-actions bot added the ci-pending PR which CI is running label Jul 17, 2024
Mario-DL
Mario-DL approved these changes Jul 17, 2024
View reviewed changes
Copy link
Member

@Mario-DL Mario-DL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@Mario-DL Mario-DL added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels Jul 18, 2024
@MiguelCompany MiguelCompany merged commit effcac4 into main Jul 18, 2024
6 checks passed
@MiguelCompany MiguelCompany deleted the feature/21300 branch July 18, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mario-DL Mario-DL Mario-DL approved these changes

Assignees
No one assigned
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@MiguelCompany @Mario-DL