[21106] Add missing documentation of netmask filter and max_msg_size_no_frag in TransportConfigQos #788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…max_msg_size_no_frag in TransportConfigQos Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
MiguelCompany
requested changes
May 28, 2024
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
|
@richiprosima Please test_3 this |
MiguelCompany
requested changes
May 29, 2024
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
|
@richiprosima Please test_3 this |
MiguelCompany
approved these changes
May 29, 2024
|
@Mergifyio backport 2.14.x |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
May 29, 2024
…in TransportConfigQos (#788) * Refs #21106: Add missing missing documentation of netmask filter and max_msg_size_no_frag in TransportConfigQos Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com> * Refs #21106: Apply suggestions Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com> * Refs #21106: Add namespace Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com> --------- Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com> (cherry picked from commit 5b807c7) # Conflicts: # code/CodeTester.cpp
8 tasks
EduPonz
added a commit
that referenced
this pull request
Jun 6, 2024
…in TransportConfigQos (#788) (#789) * Add missing documentation of netmask filter and max_msg_size_no_frag in TransportConfigQos (#788) * Refs #21106: Add missing missing documentation of netmask filter and max_msg_size_no_frag in TransportConfigQos Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com> * Refs #21106: Apply suggestions Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com> * Refs #21106: Add namespace Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com> --------- Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com> (cherry picked from commit 5b807c7) # Conflicts: # code/CodeTester.cpp * Fix conflicts Signed-off-by: eduponz <eduardoponz@eprosima.com> * Remove log error from test Signed-off-by: eduponz <eduardoponz@eprosima.com> --------- Signed-off-by: eduponz <eduardoponz@eprosima.com> Co-authored-by: elianalf <62831776+elianalf@users.noreply.github.com> Co-authored-by: eduponz <eduardoponz@eprosima.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In TransportConfigQos is missing the documentation of
@Mergifyio backport 2.14.x
Contributor Checklist
Reviewer Checklist