Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[21230] Migrate Discovery Server CI to Github #90

Merged
merged 6 commits into from
Jul 1, 2024
Merged

[21230] Migrate Discovery Server CI to Github #90

merged 6 commits into from
Jul 1, 2024

Conversation

JesusPoderoso
Copy link
Contributor

@JesusPoderoso JesusPoderoso commented Jun 27, 2024 •
edited by elianalf
Loading

Description

This PR improves the GitHub CI of this repo, to make it as similar as the one in Fast DDS

Note: While backporting this PR, please ensure the following changes:

  • Remove nightly jobs
  • Update ubuntu-ci.yml file with the proper fallback tag
  • Change fastdds.repos to fastrtps.repos
  • Fast DDS 2.6.x requires building on ubuntu-20.04
  • 1.2.x PR event request 4 workflows: one per Fast DDS branch

@Mergifyio backport 1.2.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A The added tests pass locally.
  • N/A Changes are backwards compatible.
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.

@JesusPoderoso JesusPoderoso added this to the v2.0.0 milestone Jun 27, 2024
@JesusPoderoso JesusPoderoso self-assigned this Jun 27, 2024
@JesusPoderoso JesusPoderoso requested review from richiprosima and removed request for richiprosima June 27, 2024 14:12
@JesusPoderoso
Refs #21230: Migrate Discovery Server CI to Github
8949776 
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
@JesusPoderoso
Refs #21230: Add RELEASE_SUPPORT.md file
2d598b6 
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
@JesusPoderoso JesusPoderoso requested review from richiprosima and removed request for richiprosima June 27, 2024 14:36
@JesusPoderoso
Refs #21230: Add missing flaxy test arg
f2911c7 
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
@JesusPoderoso JesusPoderoso requested review from richiprosima and removed request for richiprosima June 28, 2024 05:37
@JesusPoderoso
Refs #21230: Introduce improvements from similar PR reviews
e1da9cf 
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
@JesusPoderoso JesusPoderoso requested review from richiprosima and removed request for richiprosima June 28, 2024 20:52
elianalf
elianalf suggested changes Jul 1, 2024
View reviewed changes
.github/workflows/nightly-ubuntu-ci.yml Outdated Show resolved Hide resolved
.github/workflows/reusable-ubuntu-ci.yml Show resolved Hide resolved
.github/workflows/reusable-ubuntu-ci.yml Show resolved Hide resolved
.github/workflows/ubuntu-ci.yml Outdated Show resolved Hide resolved
.github/workflows/ubuntu-ci.yml Outdated Show resolved Hide resolved
.github/workflows/ubuntu-ci.yml Outdated Show resolved Hide resolved
@JesusPoderoso
Refs #21230: Apply rev suggestions
3c59ca2 
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
@JesusPoderoso
Refs #21230: Add missing CI checks in PR template
fe92b4c 
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
@JesusPoderoso JesusPoderoso requested review from elianalf and removed request for richiprosima and elianalf July 1, 2024 12:58
@JesusPoderoso
Copy link
Contributor Author

@Mergifyio backport 1.2.x

@JesusPoderoso JesusPoderoso merged commit c323886 into master Jul 1, 2024
3 checks passed
@JesusPoderoso JesusPoderoso deleted the feature/21230 branch July 1, 2024 14:08
@JesusPoderoso
Copy link
Contributor Author

@Mergifyio backport 1.2.x

@mergify Mergify
Copy link

mergify bot commented Jul 1, 2024 •
edited
Loading

backport 1.2.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jul 1, 2024
@JesusPoderoso @mergify
Migrate Discovery Server CI to Github (#90)
4c4824f 
* Refs #21230: Migrate Discovery Server CI to Github

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #21230: Add RELEASE_SUPPORT.md file

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #21230: Add missing flaxy test arg

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #21230:  Introduce improvements from similar PR reviews

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #21230: Apply rev suggestions

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #21230: Add missing CI checks in PR template

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

---------

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
(cherry picked from commit c323886)

# Conflicts:
#	.github/pull_request_template.md
@mergify mergify bot mentioned this pull request Jul 1, 2024
Merged
5 tasks
JesusPoderoso added a commit that referenced this pull request Jul 1, 2024
@JesusPoderoso
Migrate Discovery Server CI to Github (#90)
046a8cf 
* Refs #21230: Migrate Discovery Server CI to Github

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #21230: Add RELEASE_SUPPORT.md file

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #21230: Add missing flaxy test arg

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #21230:  Introduce improvements from similar PR reviews

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #21230: Apply rev suggestions

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #21230: Add missing CI checks in PR template

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

---------

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
(cherry picked from commit c323886)
JesusPoderoso added a commit that referenced this pull request Jul 1, 2024
@JesusPoderoso
Migrate Discovery Server CI to Github (#90)
bf75778 
* Refs #21230: Migrate Discovery Server CI to Github

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #21230: Add RELEASE_SUPPORT.md file

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #21230: Add missing flaxy test arg

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #21230:  Introduce improvements from similar PR reviews

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #21230: Apply rev suggestions

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #21230: Add missing CI checks in PR template

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

---------

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
(cherry picked from commit c323886)
JesusPoderoso added a commit that referenced this pull request Jul 2, 2024
@JesusPoderoso
Migrate Discovery Server CI to Github (#90)
61ae162 
* Refs #21230: Migrate Discovery Server CI to Github

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #21230: Add RELEASE_SUPPORT.md file

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #21230: Add missing flaxy test arg

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #21230:  Introduce improvements from similar PR reviews

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #21230: Apply rev suggestions

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #21230: Add missing CI checks in PR template

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

---------

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
(cherry picked from commit c323886)
JesusPoderoso added a commit that referenced this pull request Jul 2, 2024
@mergify @JesusPoderoso
Migrate Discovery Server CI to Github (#90) (#91)
e712b3b 
* Refs #21230: Migrate Discovery Server CI to Github

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #21230: Add RELEASE_SUPPORT.md file

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #21230: Add missing flaxy test arg

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #21230:  Introduce improvements from similar PR reviews

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #21230: Apply rev suggestions

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #21230: Add missing CI checks in PR template

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

---------

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
(cherry picked from commit c323886)

Co-authored-by: Jesús Poderoso <120394830+JesusPoderoso@users.noreply.github.com>
JesusPoderoso added a commit that referenced this pull request Jul 24, 2024
@mergify @JesusPoderoso
Migrate Discovery Server CI to Github (#90) (#91)
af53dd2 
* Refs #21230: Migrate Discovery Server CI to Github

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #21230: Add RELEASE_SUPPORT.md file

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #21230: Add missing flaxy test arg

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #21230:  Introduce improvements from similar PR reviews

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #21230: Apply rev suggestions

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #21230: Add missing CI checks in PR template

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

---------

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
(cherry picked from commit c323886)

Co-authored-by: Jesús Poderoso <120394830+JesusPoderoso@users.noreply.github.com>
JesusPoderoso added a commit that referenced this pull request Jul 24, 2024
@mergify @JesusPoderoso
Migrate Discovery Server CI to Github (#90) (#91)
91a1981 
* Refs #21230: Migrate Discovery Server CI to Github

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #21230: Add RELEASE_SUPPORT.md file

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #21230: Add missing flaxy test arg

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #21230:  Introduce improvements from similar PR reviews

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #21230: Apply rev suggestions

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #21230: Add missing CI checks in PR template

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

---------

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
(cherry picked from commit c323886)

Co-authored-by: Jesús Poderoso <120394830+JesusPoderoso@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elianalf elianalf Awaiting requested review from elianalf

Assignees

@JesusPoderoso JesusPoderoso

Labels
ci-pending
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@JesusPoderoso @elianalf