Add support for FastDDS versions earlier than 2.13 #110

irenebm · 2024-01-10T10:19:45Z

Merge after:

codecov-commenter · 2024-01-10T18:42:32Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e1b74d9) 19.61% compared to head (536f5d2) 19.24%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #110      +/-   ##
==========================================
- Coverage   19.61%   19.24%   -0.38%     
==========================================
  Files          32       32              
  Lines        2834     2832       -2     
  Branches     1501     1501              
==========================================
- Hits          556      545      -11     
- Misses       1785     1802      +17     
+ Partials      493      485       -8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Irene Bandera <irenebandera@eprosima.com>

irenebm had a problem deploying to codecov January 10, 2024 10:19 — with GitHub Actions Failure

irenebm force-pushed the feature/support_fast_versions branch from d8721e1 to 027e98f Compare January 10, 2024 15:39

irenebm temporarily deployed to codecov January 10, 2024 15:39 — with GitHub Actions Inactive

irenebm temporarily deployed to codecov January 10, 2024 16:11 — with GitHub Actions Inactive

irenebm temporarily deployed to codecov January 10, 2024 17:55 — with GitHub Actions Inactive

irenebm force-pushed the feature/support_fast_versions branch from b9dc90e to f7fb232 Compare January 10, 2024 18:37

irenebm temporarily deployed to codecov January 10, 2024 18:37 — with GitHub Actions Inactive

irenebm force-pushed the feature/support_fast_versions branch from f7fb232 to 31ac3b6 Compare January 11, 2024 13:03

irenebm had a problem deploying to codecov January 11, 2024 13:03 — with GitHub Actions Error

irenebm force-pushed the feature/support_fast_versions branch from 31ac3b6 to d025364 Compare January 11, 2024 16:39

irenebm had a problem deploying to codecov January 11, 2024 16:40 — with GitHub Actions Failure

irenebm temporarily deployed to codecov January 12, 2024 08:28 — with GitHub Actions Inactive

irenebm had a problem deploying to codecov January 12, 2024 09:42 — with GitHub Actions Failure

irenebm marked this pull request as ready for review January 12, 2024 09:45

irenebm temporarily deployed to codecov January 17, 2024 16:38 — with GitHub Actions Inactive

irenebm temporarily deployed to codecov January 18, 2024 08:11 — with GitHub Actions Inactive

irenebm temporarily deployed to codecov January 18, 2024 08:35 — with GitHub Actions Inactive

irenebm temporarily deployed to codecov January 18, 2024 09:01 — with GitHub Actions Inactive

irenebm temporarily deployed to codecov January 18, 2024 10:20 — with GitHub Actions Inactive

irenebm temporarily deployed to codecov January 18, 2024 13:26 — with GitHub Actions Inactive

irenebm temporarily deployed to codecov January 18, 2024 15:23 — with GitHub Actions Inactive

irenebm had a problem deploying to codecov January 19, 2024 11:34 — with GitHub Actions Failure

irenebm temporarily deployed to codecov January 19, 2024 13:24 — with GitHub Actions Inactive

irenebm force-pushed the feature/support_fast_versions branch from 16637eb to 886601d Compare January 19, 2024 13:51

irenebm had a problem deploying to codecov January 19, 2024 13:51 — with GitHub Actions Failure

irenebm temporarily deployed to codecov January 19, 2024 14:03 — with GitHub Actions Inactive

Add support for FastDDS versions earlier than 2.13

9b3cd3b

Signed-off-by: Irene Bandera <irenebandera@eprosima.com>

irenebm added 3 commits January 23, 2024 11:29

Uncrustify

24c7d0c

Signed-off-by: Irene Bandera <irenebandera@eprosima.com>

Apply changes

4602393

Signed-off-by: Irene Bandera <irenebandera@eprosima.com>

Add ddsrecorder_tool tests

97bf976

Signed-off-by: Irene Bandera <irenebandera@eprosima.com>

irenebm force-pushed the feature/support_fast_versions branch from 886601d to 97bf976 Compare January 23, 2024 10:29

irenebm temporarily deployed to codecov January 23, 2024 10:29 — with GitHub Actions Inactive

irenebm temporarily deployed to codecov January 23, 2024 14:05 — with GitHub Actions Inactive

rsanchez15 previously approved these changes Jan 25, 2024

View reviewed changes

Uncrustify

536f5d2

Signed-off-by: Irene Bandera <irenebandera@eprosima.com>

irenebm dismissed rsanchez15’s stale review via 536f5d2 January 25, 2024 07:44

irenebm temporarily deployed to codecov January 25, 2024 07:45 — with GitHub Actions Inactive

rsanchez15 approved these changes Jan 25, 2024

View reviewed changes

rsanchez15 merged commit b388f09 into main Jan 25, 2024
16 of 18 checks passed

rsanchez15 deleted the feature/support_fast_versions branch January 25, 2024 08:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for FastDDS versions earlier than 2.13 #110

Add support for FastDDS versions earlier than 2.13 #110

irenebm commented Jan 10, 2024 •

edited

Loading

codecov-commenter commented Jan 10, 2024 •

edited

Loading

Add support for FastDDS versions earlier than 2.13 #110

Add support for FastDDS versions earlier than 2.13 #110

Conversation

irenebm commented Jan 10, 2024 • edited Loading

codecov-commenter commented Jan 10, 2024 • edited Loading

Codecov Report

irenebm commented Jan 10, 2024 •

edited

Loading

codecov-commenter commented Jan 10, 2024 •

edited

Loading