Add support for FastDDS versions earlier than 2.13 #82

irenebm · 2024-01-10T19:03:27Z

Merge after:

codecov-commenter · 2024-01-11T09:17:40Z

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (16b1acb) 36.78% compared to head (dfcb11c) 36.78%.

Files	Patch %	Lines
...e_participants/src/cpp/reader/dds/CommonReader.cpp	25.00%	0 Missing and 3 partials ⚠️
...e_participants/src/cpp/writer/dds/CommonWriter.cpp	75.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main      #82   +/-   ##
=======================================
  Coverage   36.78%   36.78%           
=======================================
  Files         116      116           
  Lines        4975     4983    +8     
  Branches     1909     1913    +4     
=======================================
+ Hits         1830     1833    +3     
  Misses       2332     2332           
- Partials      813      818    +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Irene Bandera <irenebandera@eprosima.com>

ddspipe_core/CMakeLists.txt

ddspipe_participants/src/cpp/reader/dds/CommonReader.cpp

ddspipe_participants/src/cpp/writer/dds/CommonWriter.cpp

ddspipe_core/CMakeLists.txt

Signed-off-by: Irene Bandera <irenebandera@eprosima.com>

rsanchez15 · 2024-01-22T07:50:06Z

ddspipe_core/CMakeLists.txt

+    set(DDS_TYPES_VERSION "/v2/")
+else()
+    set(DDS_TYPES_VERSION "/v1/")


Suggested change

set(DDS_TYPES_VERSION "/v2/")

else()

set(DDS_TYPES_VERSION "/v1/")

set(DDS_TYPES_VERSION "/v1/")

else()

set(DDS_TYPES_VERSION "/v2/")

rsanchez15 · 2024-01-22T07:57:25Z

ddspipe_core/CMakeLists.txt

+file(GLOB_RECURSE TEST_FILES "${PROJECT_SOURCE_DIR}/test/")
+foreach(TEST_FILE ${TEST_FILES})
+    if(NOT TEST_FILE MATCHES ${DDS_TYPES_VERSION})
+    compile_test_library(${TEST_FILE})
+    endif()
+endforeach()


This has the same issue as we already resolved for the router. You are setting test files while the function request the path to tests.

Signed-off-by: Irene Bandera <irenebandera@eprosima.com>

rsanchez15

LGTM 🚀

* Add support for FastDDS versions earlier than 2.13 Signed-off-by: Irene Bandera <irenebandera@eprosima.com> * FASTDDS_SUBDIRECTORY -> DDS_TYPES_VERSION Signed-off-by: Irene Bandera <irenebandera@eprosima.com> * Apply changes Signed-off-by: Irene Bandera <irenebandera@eprosima.com> * Correct function names Signed-off-by: Irene Bandera <irenebandera@eprosima.com> * Update FASTRTPS version check in CommonReader and CommonWriter Signed-off-by: Irene Bandera <irenebandera@eprosima.com> * Uncrustify Signed-off-by: Irene Bandera <irenebandera@eprosima.com> * Compile test libraries in ddspipe_core Signed-off-by: Irene Bandera <irenebandera@eprosima.com> --------- Signed-off-by: Irene Bandera <irenebandera@eprosima.com>

irenebm had a problem deploying to codecov January 10, 2024 19:03 — with GitHub Actions Failure

irenebm force-pushed the feature/support_fast_versions branch from 10af4b2 to 1eb3a85 Compare January 11, 2024 07:13

irenebm had a problem deploying to codecov January 11, 2024 07:13 — with GitHub Actions Error

irenebm force-pushed the feature/support_fast_versions branch from 1eb3a85 to c294420 Compare January 11, 2024 07:54

irenebm had a problem deploying to codecov January 11, 2024 07:55 — with GitHub Actions Failure

irenebm force-pushed the feature/support_fast_versions branch from c294420 to cf6dbf8 Compare January 11, 2024 08:58

irenebm temporarily deployed to codecov January 11, 2024 08:58 — with GitHub Actions Inactive

irenebm mentioned this pull request Jan 11, 2024

Add support for FastDDS versions earlier than 2.13 eProsima/DDS-Record-Replay#110

Merged

Add support for FastDDS versions earlier than 2.13

9e6d5aa

Signed-off-by: Irene Bandera <irenebandera@eprosima.com>

irenebm force-pushed the feature/support_fast_versions branch from cf6dbf8 to 9e6d5aa Compare January 11, 2024 16:40

irenebm temporarily deployed to codecov January 11, 2024 16:40 — with GitHub Actions Inactive

irenebm marked this pull request as ready for review January 11, 2024 16:42

rsanchez15 self-requested a review January 12, 2024 07:17

FASTDDS_SUBDIRECTORY -> DDS_TYPES_VERSION

95ba5ac

Signed-off-by: Irene Bandera <irenebandera@eprosima.com>

irenebm temporarily deployed to codecov January 12, 2024 09:44 — with GitHub Actions Inactive

rsanchez15 requested changes Jan 12, 2024

View reviewed changes

ddspipe_core/CMakeLists.txt Outdated Show resolved Hide resolved

irenebm mentioned this pull request Jan 16, 2024

Add support for FastDDS versions earlier than 2.13 eProsima/DDS-Router#424

Merged

rsanchez15 requested changes Jan 16, 2024

View reviewed changes

ddspipe_participants/src/cpp/reader/dds/CommonReader.cpp Outdated Show resolved Hide resolved

ddspipe_participants/src/cpp/writer/dds/CommonWriter.cpp Outdated Show resolved Hide resolved

ddspipe_core/CMakeLists.txt Outdated Show resolved Hide resolved

Apply changes

a4b5e49

Signed-off-by: Irene Bandera <irenebandera@eprosima.com>

irenebm temporarily deployed to codecov January 17, 2024 13:24 — with GitHub Actions Inactive

rsanchez15 approved these changes Jan 17, 2024

View reviewed changes

Correct function names

5dcfd24

Signed-off-by: Irene Bandera <irenebandera@eprosima.com>

irenebm temporarily deployed to codecov January 17, 2024 15:36 — with GitHub Actions Inactive

rsanchez15 had a problem deploying to codecov January 17, 2024 16:44 — with GitHub Actions Error

irenebm temporarily deployed to codecov January 19, 2024 11:40 — with GitHub Actions Inactive

irenebm temporarily deployed to codecov January 19, 2024 12:00 — with GitHub Actions Inactive

irenebm added 2 commits January 22, 2024 08:46

Update FASTRTPS version check in CommonReader and CommonWriter

4c0071e

Signed-off-by: Irene Bandera <irenebandera@eprosima.com>

Uncrustify

9253fc5

Signed-off-by: Irene Bandera <irenebandera@eprosima.com>

irenebm force-pushed the feature/support_fast_versions branch from 36c1a02 to 9253fc5 Compare January 22, 2024 07:46

irenebm temporarily deployed to codecov January 22, 2024 07:46 — with GitHub Actions Inactive

rsanchez15 requested changes Jan 22, 2024

View reviewed changes

irenebm temporarily deployed to codecov January 22, 2024 08:34 — with GitHub Actions Inactive

irenebm force-pushed the feature/support_fast_versions branch from 9952e0c to 1300101 Compare January 22, 2024 08:41

irenebm temporarily deployed to codecov January 22, 2024 08:41 — with GitHub Actions Inactive

irenebm had a problem deploying to codecov January 22, 2024 10:28 — with GitHub Actions Failure

irenebm had a problem deploying to codecov January 22, 2024 10:36 — with GitHub Actions Failure

irenebm force-pushed the feature/support_fast_versions branch from 1300101 to e56d861 Compare January 22, 2024 15:02

irenebm had a problem deploying to codecov January 22, 2024 15:02 — with GitHub Actions Error

irenebm had a problem deploying to codecov January 22, 2024 15:03 — with GitHub Actions Error

Compile test libraries in ddspipe_core

dfcb11c

Signed-off-by: Irene Bandera <irenebandera@eprosima.com>

irenebm force-pushed the feature/support_fast_versions branch from e56d861 to dfcb11c Compare January 22, 2024 15:19

irenebm temporarily deployed to codecov January 22, 2024 15:19 — with GitHub Actions Inactive

irenebm temporarily deployed to codecov January 22, 2024 15:20 — with GitHub Actions Inactive

rsanchez15 approved these changes Jan 23, 2024

View reviewed changes

rsanchez15 merged commit 3b41d0d into main Jan 23, 2024
45 of 46 checks passed

rsanchez15 deleted the feature/support_fast_versions branch January 23, 2024 09:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for FastDDS versions earlier than 2.13 #82

Add support for FastDDS versions earlier than 2.13 #82

irenebm commented Jan 10, 2024 •

edited by rsanchez15

Loading

codecov-commenter commented Jan 11, 2024 •

edited

Loading

rsanchez15 Jan 22, 2024

rsanchez15 Jan 22, 2024

rsanchez15 left a comment

Add support for FastDDS versions earlier than 2.13 #82

Add support for FastDDS versions earlier than 2.13 #82

Conversation

irenebm commented Jan 10, 2024 • edited by rsanchez15 Loading

codecov-commenter commented Jan 11, 2024 • edited Loading

Codecov Report

rsanchez15 Jan 22, 2024

Choose a reason for hiding this comment

rsanchez15 Jan 22, 2024

Choose a reason for hiding this comment

rsanchez15 left a comment

Choose a reason for hiding this comment

irenebm commented Jan 10, 2024 •

edited by rsanchez15

Loading

codecov-commenter commented Jan 11, 2024 •

edited

Loading