Login flow consistency: Do not use redirect in admin area login box

[Deltik]

Fixes: #4779

Motivation and Context

The non-admin login flow does not perform a redirect, but the admin login flow did. This led to an inconsistency in how the authentication error message was passed.

Description

The login failure redirect on the admin area login page (/e107_admin/admin.php) has been removed.

How Has This Been Tested?

\AdminLoginCest::testAdminFailedLogin() now checks that the login failure message is displayed in the admin area login page on failed login.

Types of Changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Performance enhancement (non-breaking change which improves efficiency)
• Code cleanup (non-breaking change which makes code smaller or more readable)
• Breaking change (fix or feature that would cause existing functionality to change)
• Documentation (a change to man pages or other documentation)

Checklist

• My code adheres to the e107 code style standard.
• I have read the contributing document.
• I have added tests to cover my changes.
• All new and existing tests pass.

[codeclimate]

Code Climate has analyzed commit 00b1d75 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 25.0% (80% is the threshold).

This pull request will bring the total coverage in the repository to 34.4% (0.1% change).

View more on Code Climate.

[CaMer0n]

Thank you! 👍