No warning / alert with wrong login... #4779
Assignees
Labels
type: bug
A problem that should not be happening
Comments
Alex-e107nl
changed the title
|
Confirmed. Still issue. |
Deltik
added a commit
to Deltik/e107
that referenced
this issue
Sep 7, 2022
The non-admin login flow does not perform a redirect, but the admin login flow did. This led to an inconsistency in how the authentication error message was passed. Fixes: e107inc#4779
10 tasks
Jimmi08
pushed a commit
to hpkizi/e107
that referenced
this issue
Sep 8, 2022
The non-admin login flow does not perform a redirect, but the admin login flow did. This led to an inconsistency in how the authentication error message was passed. Fixes: e107inc/e107#4779
CaMer0n
added a commit
that referenced
this issue
Sep 29, 2022
Fixes: #4779 Login flow consistency: Do not use redirect in admin area login box
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bug Description
When logging in goes wrong there's no alert, only when you click on a link it shows....
How to Reproduce
Steps to reproduce the behavior:
Expected Behavior
Should be directly shown...
Server Information
e107 - Versie 2.3.3 (git)
Site thema - bootstrap3
Beheer thema - Bootstrap 3 v1.0 Door e107 Inc (2013-12-25)
Installatiedatum - donderdag 14 april 2016 - 09:27
Server - Apache/2 - (Systeem: e107.nl)
MySQL - 5.6.51 - PDO: Aan
PHP Operating System
PHP Versie - 7.3.31
Client Information
Your user agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:100.0) Gecko/20100101 Firefox/100.0
Additional Information
Oke, found the problem...
in
e107_handlers/login.php line 640
e107::getMessage()->reset()->addError($message, 'default', true); changed to
e107::getMessage()->reset()->addError($message);
And the alert shows as it's supposed to but i really do not know why... was changed with fd42d23 by Cameron, but it's only a quick and dirty fix because the problem is now in the admin section but that's less of a problem to me..
The text was updated successfully, but these errors were encountered: