Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[esc] key cancels editing mode (without saving) #64

Closed
2 tasks done
nelsonic opened this issue Sep 6, 2018 · 1 comment
Closed
2 tasks done

[esc] key cancels editing mode (without saving) #64

nelsonic opened this issue Sep 6, 2018 · 1 comment
Assignees
@nelsonic
Labels
enhancement in-progress T4h

Comments

@nelsonic
Copy link
Member

nelsonic commented Sep 6, 2018 •
edited
Loading

According to: https://github.com/tastejs/todomvc/blob/master/app-spec.md#editing

If escape is pressed during the edit, the edit state should be left and any changes be discarded.

and the test assertions: https://github.com/tastejs/todomvc/tree/master/tests#example-output

✓ should cancel edits on escape (1115ms)
  • Add keyboard event listener case in subscriptions for [esc] key
  • Trigger signal('CANCEL')() to cancel editing without saving changes.
This was referenced Sep 6, 2018
Merged
Closed
@nelsonic
Copy link
Member Author

nelsonic commented Sep 6, 2018

cancel-editing-on-esc-keypress-test-passing

@nelsonic nelsonic self-assigned this Sep 6, 2018
nelsonic added a commit that referenced this issue Sep 6, 2018
@nelsonic
add test for [esc] CANCEL ediing for #64
4fdb098
nelsonic added a commit that referenced this issue Sep 6, 2018
@nelsonic
add implementation for [esc] CANCEL editing fixes #64
d812e6c
@nelsonic nelsonic closed this as completed Sep 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nelsonic nelsonic

Labels
enhancement in-progress T4h
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nelsonic