Drop dimod 0.8.x support and fix CI #259
Conversation
Version 0.8 is now almost 2 years old, and most Ocean packages already dropped support for it, so it's becoming a pain to maintain the whole collection of packages compatible (primarily samplers: neal, tabu, greedy) and tested.
randomir
force-pushed
the
drop-dimod-0.8-support
branch
from
2b1413d to
5cd5091
Compare
In the process, we had to increase the lower bound of dimod to 0.9.6, due to dwave-networx, dwave-neal and numpy conflicts.
randomir
force-pushed
the
drop-dimod-0.8-support
branch
from
e4e0b33 to
e61fe6d
Compare
randomir
force-pushed
the
drop-dimod-0.8-support
branch
from
e61fe6d to
96cfe37
Compare
randomir
changed the title
| # Include dwave-preprocessing, as dimod went back and forth with | ||
| # including it as a core dependency vs extra. Make it unbounded, | ||
| # as it's already constrained by dimod (if required). | ||
| 'dwave-preprocessing', |
There was a problem hiding this comment.
I believe pip's version resolution order will fail if we release a version of dwave-preprocessing that's outside of dimod's version constraints. Since it does something like bfs
There was a problem hiding this comment.
Not sure I understand what you mean?
There was a problem hiding this comment.
IIRC, it will first install everything listed here using the ranges specified here. So dwave-preprocessing will be unbounded. Then it will install the dependencies of the dependencies and discover that dimod (may) require something smaller. I could be misremembering though the order.
There was a problem hiding this comment.
Perhaps, but dimod doesn't constrain dwave-preprocessing anymore, right?
There was a problem hiding this comment.
Of course, you're right.
FWIW dimod and dwave-preprocessing are linked at the C++ level, and when we merge dwavesystems/dimod#1043 that will constitute a breaking change for dwave-preprocessing.
New Features --- - Add `hybrid.Log`, a block to log user-define state metrics to a JSON file, python logger, or in-memory queue or list. See dwavesystems#257. - Add convenience JSON encoders for commonly used NumPy (`hybrid.utils.NumpyEncoder`) and Ocean types (`hybrid.utils.OceanEncoder`). See dwavesystems#257. Fixes --- - Clarify docs, dwavesystems#142. Upgrade --- - Drop dimod 0.8.x support. Oldest supported dimod version is now 0.9.6. See dwavesystems#259.
Support
dimod>=0.9.6and make dependency versions consistent.Fix CI to correctly sweep supported versions of dependencies. Close #258.